vinyl-cache/lib/libvcc/vcc_vmod.c
0
/*-
1
 * Copyright (c) 2010-2015 Varnish Software AS
2
 * All rights reserved.
3
 *
4
 * Author: Poul-Henning Kamp <phk@phk.freebsd.dk>
5
 *
6
 * SPDX-License-Identifier: BSD-2-Clause
7
 *
8
 * Redistribution and use in source and binary forms, with or without
9
 * modification, are permitted provided that the following conditions
10
 * are met:
11
 * 1. Redistributions of source code must retain the above copyright
12
 *    notice, this list of conditions and the following disclaimer.
13
 * 2. Redistributions in binary form must reproduce the above copyright
14
 *    notice, this list of conditions and the following disclaimer in the
15
 *    documentation and/or other materials provided with the distribution.
16
 *
17
 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
18
 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
19
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
20
 * ARE DISCLAIMED.  IN NO EVENT SHALL AUTHOR OR CONTRIBUTORS BE LIABLE
21
 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
22
 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
23
 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
24
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
25
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
26
 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
27
 * SUCH DAMAGE.
28
 *
29
 * Parse `import`, check metadata and versioning.
30
 *
31
 */
32
33
#include "config.h"
34
35
#include <stdlib.h>
36
#include <string.h>
37
38
#include "vcc_compile.h"
39
40
#include "libvcc.h"
41
#include "vfil.h"
42
#include "vjsn.h"
43
#include "vmod_abi.h"
44
45
#include "vcc_vmod.h"
46
47
struct vmod_import {
48
        unsigned                        magic;
49
#define VMOD_IMPORT_MAGIC               0x31803a5d
50
        const char                      *err;
51
        struct vsb                      *json;
52
        char                            *path;
53
        VTAILQ_ENTRY(vmod_import)       list;
54
        int                             from_vext;
55
        int                             unimported_vext;
56
57
        // From $VMOD
58
        double                          vmod_syntax;
59
        char                            *name;
60
        char                            *func_name;
61
        char                            *file_id;
62
        char                            *abi;
63
        unsigned                        major;
64
        unsigned                        minor;
65
66
        struct symbol                   *sym;
67
        const struct token              *t_mod;
68
        struct vjsn                     *vj;
69
#define STANZA(UU, ll, ss)              int n_##ll;
70
        STANZA_TBL
71
#undef STANZA
72
};
73
74
static VTAILQ_HEAD(,vmod_import) imports = VTAILQ_HEAD_INITIALIZER(imports);
75
76
typedef void vcc_do_stanza_f(struct vcc *tl, const struct vmod_import *vim,
77
    const struct vjsn_val *vv);
78
79
static int
80 2452
vcc_Extract_JSON(struct vmod_import *vim, const char *filename)
81
{
82 2452
        const char *magic = "VMOD_JSON_SPEC\x02", *p;
83
        int c;
84
        FILE *f;
85
86 2452
        CHECK_OBJ_NOTNULL(vim, VMOD_IMPORT_MAGIC);
87 2452
        AN(filename);
88
89 2452
        f = fopen(filename, "rb");
90 2452
        if (f == NULL) {
91 4
                vim->err = strerror(errno);
92 4
                return (-1);
93
        }
94
95 2448
        p = magic;
96 2448
        vim->err = "No VMOD JSON found";
97 204760
        while (1) {
98 50146116
                c = getc(f);
99 50146116
                if (c == EOF) {
100 4
                        AZ(fclose(f));
101 4
                        vim->err = "No VMOD JSON found";
102 4
                        return (-1);
103
                }
104 50146112
                if (c != *p) {
105 49941356
                        p = magic;
106 49941356
                        continue;
107
                }
108 204756
                p++;
109 204756
                if (*p == '\0')
110 2444
                        break;
111
        }
112
113 2444
        vim->json = VSB_new_auto();
114 2444
        AN(vim->json);
115
116 50192292
        while (1) {
117 50192292
                c = getc(f);
118 50192292
                if (c == EOF) {
119 4
                        AZ(fclose(f));
120 4
                        vim->err = "Truncated VMOD JSON";
121 4
                        VSB_destroy(&vim->json);
122 4
                        return (-1);
123
                }
124 50192288
                if (c == '\x03')
125 2440
                        break;
126 50189848
                VSB_putc(vim->json, c);
127
        }
128 2440
        AZ(fclose(f));
129 2440
        AZ(VSB_finish(vim->json));
130 2440
        return (0);
131 2452
}
132
133
static const char *
134 2440
vcc_ParseJSON(const struct vcc *tl, const char *jsn, struct vmod_import *vim)
135
{
136
        const struct vjsn_val *vv, *vv2, *vv3;
137
        const char *err;
138
        char *p;
139
140 2440
        vim->vj = vjsn_parse(jsn, &err);
141 2440
        if (err != NULL)
142 4
                return (err);
143 2436
        AN(vim->vj);
144
145 2436
        vv = vim->vj->value;
146 2436
        if (!vjsn_is_array(vv))
147 4
                return ("Not array[0]");
148
149 2432
        vv2 = VTAILQ_FIRST(&vv->children);
150 2432
        AN(vv2);
151 2432
        if (!vjsn_is_array(vv2))
152 4
                return ("Not array[1]");
153 2428
        vv3 = VTAILQ_FIRST(&vv2->children);
154 2428
        AN(vv3);
155 2428
        if (!vjsn_is_string(vv3))
156 4
                return ("Not string[2]");
157 2424
        if (vstrcmp(vv3->value, "$VMOD"))
158 4
                return ("Not $VMOD[3]");
159
160 2420
        vv3 = VTAILQ_NEXT(vv3, list);
161 2420
        AN(vv3);
162 2420
        assert(vjsn_is_string(vv3));
163 2420
        vim->vmod_syntax = strtod(vv3->value, NULL);
164 2420
        if (vim->vmod_syntax != 2.0)
165 4
                return ("Syntax != 2.0");
166
167 2416
        vv3 = VTAILQ_NEXT(vv3, list);
168 2416
        AN(vv3);
169 2416
        assert(vjsn_is_string(vv3));
170 2416
        vim->name = vv3->value;
171
172 2416
        vv3 = VTAILQ_NEXT(vv3, list);
173 2416
        AN(vv3);
174 2416
        assert(vjsn_is_string(vv3));
175 2416
        vim->func_name = vv3->value;
176
177 2416
        vv3 = VTAILQ_NEXT(vv3, list);
178 2416
        AN(vv3);
179 2416
        assert(vjsn_is_string(vv3));
180 2416
        vim->file_id = vv3->value;
181
182 2416
        vv3 = VTAILQ_NEXT(vv3, list);
183 2416
        AN(vv3);
184 2416
        assert(vjsn_is_string(vv3));
185 2416
        vim->abi = vv3->value;
186
187 2416
        vv3 = VTAILQ_NEXT(vv3, list);
188 2416
        AN(vv3);
189 2416
        assert(vjsn_is_string(vv3));
190 2416
        vim->major = strtoul(vv3->value, &p, 10);
191 2416
        assert(p == NULL || *p == '\0' || *p == 'U');
192
193 2416
        vv3 = VTAILQ_NEXT(vv3, list);
194 2416
        AN(vv3);
195 2416
        assert(vjsn_is_string(vv3));
196 2416
        vim->minor = strtoul(vv3->value, &p, 10);
197 2416
        assert(p == NULL || *p == '\0' || *p == 'U');
198
199
200 2416
        if (vim->major == 0 && vim->minor == 0 &&
201 1852
            vstrcmp(vim->abi, VMOD_ABI_Version)) {
202 4
                VSB_printf(tl->sb, "Incompatible VMOD %.*s\n", PF(vim->t_mod));
203 4
                VSB_printf(tl->sb, "\tFile name: %s\n", vim->path);
204 8
                VSB_printf(tl->sb, "\tABI mismatch, expected <%s>, got <%s>\n",
205 4
                           VMOD_ABI_Version, vim->abi);
206 4
                return ("");
207
        }
208 2972
        if (vim->major != 0 &&
209 564
            (vim->major != VRT_MAJOR_VERSION ||
210 560
            vim->minor > VRT_MINOR_VERSION)) {
211 4
                VSB_printf(tl->sb, "Incompatible VMOD %.*s\n", PF(vim->t_mod));
212 4
                VSB_printf(tl->sb, "\tFile name: %s\n", vim->path);
213 8
                VSB_printf(tl->sb, "\tVMOD wants ABI version %u.%u\n",
214 4
                    vim->major, vim->minor);
215 4
                VSB_printf(tl->sb, "\tvinyld provides ABI version %u.%u\n",
216
                    VRT_MAJOR_VERSION, VRT_MINOR_VERSION);
217 4
                return ("");
218
        }
219
220
221 92800
        VTAILQ_FOREACH(vv2, &vv->children, list) {
222 90396
                assert (vjsn_is_array(vv2));
223 90396
                vv3 = VTAILQ_FIRST(&vv2->children);
224 90396
                assert(vjsn_is_string(vv3));
225 90396
                assert(vv3->value[0] == '$');
226
#define STANZA(UU, ll, ss) \
227
    if (!vstrcmp(vv3->value, "$" #UU)) {vim->n_##ll++; continue;}
228 90396
                STANZA_TBL
229
#undef STANZA
230 4
                return ("Unknown metadata stanza.");
231
        }
232 2404
        if (vim->n_cproto != 1)
233 4
                return ("Bad cproto stanza(s)");
234 2400
        if (vim->n_vmod != 1)
235 4
                return ("Bad vmod stanza(s)");
236 2396
        return (NULL);
237 2440
}
238
239
/*
240
 * Load and check the metadata from the objectfile containing the vmod
241
 */
242
243
static int
244 2440
vcc_VmodLoad(struct vcc *tl, struct vmod_import *vim)
245
{
246
        static const char *err;
247
        struct vmod_import *vim2;
248
249 2440
        CHECK_OBJ_NOTNULL(vim, VMOD_IMPORT_MAGIC);
250
251 2440
        err = vcc_ParseJSON(tl, VSB_data(vim->json), vim);
252 2440
        if (err != NULL && *err != '\0') {
253 72
                VSB_printf(tl->sb,
254 36
                    "VMOD %.*s: bad metadata\n", PF(vim->t_mod));
255 36
                VSB_printf(tl->sb, "\t(%s)\n", err);
256 36
                VSB_printf(tl->sb, "\tFile name: %s\n", vim->path);
257 36
        }
258
259 2440
        if (err != NULL)
260 44
                return (-1);
261
262 2988
        VTAILQ_FOREACH(vim2, &imports, list) {
263 608
                if (vstrcmp(vim->name, vim2->name))
264 592
                        continue;
265 16
                if (!vstrcmp(vim->file_id, vim2->file_id)) {
266
                        // (Truly) duplicate imports are OK
267 12
                        return (0);
268
                }
269 8
                VSB_printf(tl->sb,
270
                    "Different version of VMOD %.*s already loaded\n",
271 4
                    PF(vim->t_mod));
272 4
                vcc_ErrWhere(tl, vim->t_mod);
273 4
                VSB_cat(tl->sb, "Previous import at:\n");
274 4
                vcc_ErrWhere(tl, vim2->t_mod);
275 4
                vcc_Warn(tl);
276 4
                break;
277
        }
278 2384
        VTAILQ_INSERT_TAIL(&imports, vim, list);
279
280 2384
        return (0);
281 2440
}
282
283
static void v_matchproto_(vcc_do_stanza_f)
284 512
vcc_do_event(struct vcc *tl, const struct vmod_import *vim,
285
    const struct vjsn_val *vv)
286
{
287
        struct inifin *ifp;
288
289 512
        ifp = New_IniFin(tl);
290 1024
        VSB_printf(ifp->ini,
291
            "\tif (%s(ctx, &vmod_priv_%s, VCL_EVENT_LOAD))\n"
292
            "\t\treturn(1);",
293 512
            vv->value, vim->sym->vmod_name);
294 1024
        VSB_printf(ifp->fin,
295
            "\t\t(void)%s(ctx, &vmod_priv_%s,\n"
296
            "\t\t\t    VCL_EVENT_DISCARD);",
297 512
            vv->value, vim->sym->vmod_name);
298 1024
        VSB_printf(ifp->event, "%s(ctx, &vmod_priv_%s, ev)",
299 512
            vv->value, vim->sym->vmod_name);
300 512
}
301
302
static void v_matchproto_(vcc_do_stanza_f)
303 2368
vcc_do_cproto(struct vcc *tl, const struct vmod_import *vim,
304
    const struct vjsn_val *vv)
305
{
306 2368
        (void)vim;
307 2368
        do {
308 472024
                assert (vjsn_is_string(vv));
309 472024
                Fh(tl, 0, "%s\n", vv->value);
310 472024
                vv = VTAILQ_NEXT(vv, list);
311 472024
        } while(vv != NULL);
312 2368
}
313
314
static void
315 4736
vcc_vj_foreach(struct vcc *tl, const struct vmod_import *vim,
316
    const char *stanza, vcc_do_stanza_f *func)
317
{
318
        const struct vjsn_val *vv, *vv2, *vv3;
319
320 4736
        vv = vim->vj->value;
321 4736
        assert (vjsn_is_array(vv));
322 182088
        VTAILQ_FOREACH(vv2, &vv->children, list) {
323 177352
                assert (vjsn_is_array(vv2));
324 177352
                vv3 = VTAILQ_FIRST(&vv2->children);
325 177352
                assert (vjsn_is_string(vv3));
326 177352
                if (!vstrcmp(vv3->value, stanza))
327 2880
                        func(tl, vim, VTAILQ_NEXT(vv3, list));
328 177352
        }
329 4736
}
330
331
static void
332 2368
vcc_emit_setup(struct vcc *tl, const struct vmod_import *vim)
333
{
334
        struct inifin *ifp;
335 2368
        const struct token *mod = vim->t_mod;
336
337 2368
        ifp = New_IniFin(tl);
338
339 2368
        VSB_cat(ifp->ini, "\tif (VPI_Vmod_Init(ctx,\n");
340 2368
        VSB_printf(ifp->ini, "\t    &VGC_vmod_%.*s,\n", PF(mod));
341 2368
        VSB_printf(ifp->ini, "\t    %u,\n", tl->vmod_count++);
342 2368
        VSB_printf(ifp->ini, "\t    &%s,\n", vim->func_name);
343 2368
        VSB_printf(ifp->ini, "\t    sizeof(%s),\n", vim->func_name);
344 2368
        VSB_printf(ifp->ini, "\t    \"%.*s\",\n", PF(mod));
345 2368
        VSB_cat(ifp->ini, "\t    ");
346 2368
        VSB_quote(ifp->ini, vim->path, -1, VSB_QUOTE_CSTR);
347 2368
        VSB_cat(ifp->ini, ",\n");
348 2368
        AN(vim->file_id);
349 2368
        VSB_printf(ifp->ini, "\t    \"%s\",\n", vim->file_id);
350 2368
        if (vim->from_vext) {
351 8
                VSB_cat(ifp->ini, "\t    ");
352 8
                VSB_quote(ifp->ini, vim->path, -1, VSB_QUOTE_CSTR);
353 8
                VSB_cat(ifp->ini, "\n");
354 8
        } else {
355 4720
                VSB_printf(ifp->ini, "\t    \"./vmod_cache/_vmod_%.*s.%s\"\n",
356 2360
                    PF(mod), vim->file_id);
357
        }
358 2368
        VSB_cat(ifp->ini, "\t    ))\n");
359 2368
        VSB_cat(ifp->ini, "\t\treturn(1);");
360
361 2368
        VSB_cat(tl->symtab, ",\n    {\n");
362 2368
        VSB_cat(tl->symtab, "\t\"dir\": \"import\",\n");
363 2368
        VSB_cat(tl->symtab, "\t\"type\": \"$VMOD\",\n");
364 2368
        VSB_printf(tl->symtab, "\t\"name\": \"%.*s\",\n", PF(mod));
365 2368
        if (vim->from_vext)
366 8
                VSB_cat(tl->symtab, "\t\"vext\": true,\n");
367
        else
368 2360
                VSB_cat(tl->symtab, "\t\"vext\": false,\n");
369 2368
        VSB_printf(tl->symtab, "\t\"file\": \"%s\",\n", vim->path);
370 4736
        VSB_printf(tl->symtab, "\t\"dst\": \"./vmod_cache/_vmod_%.*s.%s\"\n",
371 2368
            PF(mod), vim->file_id);
372 2368
        VSB_cat(tl->symtab, "    }");
373
374
        /* XXX: zero the function pointer structure ?*/
375 4736
        VSB_printf(ifp->fin, "\t\tVRT_priv_fini(ctx, &vmod_priv_%.*s);",
376 2368
            PF(mod));
377 4736
        VSB_printf(ifp->final, "\t\tVPI_Vmod_Unload(ctx, &VGC_vmod_%.*s);",
378 2368
            PF(mod));
379
380 2368
        vcc_vj_foreach(tl, vim, "$EVENT", vcc_do_event);
381
382 2368
        Fh(tl, 0, "\n/* --- BEGIN VMOD %.*s --- */\n\n", PF(mod));
383 2368
        Fh(tl, 0, "static struct vmod *VGC_vmod_%.*s;\n", PF(mod));
384 2368
        Fh(tl, 0, "static struct vmod_priv vmod_priv_%.*s;\n", PF(mod));
385
386 2368
        vcc_vj_foreach(tl, vim, "$CPROTO", vcc_do_cproto);
387
388 2368
        Fh(tl, 0, "\n/* --- END VMOD %.*s --- */\n\n", PF(mod));
389 2368
}
390
391
static void
392 84
vcc_vim_destroy(struct vmod_import **vimp)
393
{
394
        struct vmod_import *vim;
395
396 84
        TAKE_OBJ_NOTNULL(vim, vimp, VMOD_IMPORT_MAGIC);
397 84
        if (vim->path)
398 80
                free(vim->path);
399 84
        if (vim->vj)
400 64
                vjsn_delete(&vim->vj);
401 84
        if (vim->json)
402 68
                VSB_destroy(&vim->json);
403 84
        FREE_OBJ(vim);
404 84
}
405
406
static int
407 2444
vcc_path_open(void *priv, const char *fn)
408
{
409
        struct vmod_import *vim;
410
411 2444
        CAST_OBJ_NOTNULL(vim, priv, VMOD_IMPORT_MAGIC);
412 2444
        AN(fn);
413
414 2444
        return (vcc_Extract_JSON(vim, fn));
415
}
416
417
void
418 2468
vcc_ParseImport(struct vcc *tl)
419
{
420
        char fn[1024];
421
        const char *p;
422
        struct token *mod, *tmod, *t1;
423
        struct symbol *msym, *vsym;
424 2468
        struct vmod_import *vim = NULL;
425
        const struct vmod_import *vimold;
426
427 2468
        t1 = tl->t;
428 2468
        SkipToken(tl, ID);              /* "import" */
429
430 2468
        ExpectErr(tl, ID);              /* "vmod_name" */
431 2468
        mod = tl->t;
432 2468
        tmod = vcc_PeekTokenFrom(tl, mod);
433 2468
        AN(tmod);
434 2468
        if (tmod->tok == ID && vcc_IdIs(tmod, "as")) {
435 20
                vcc_NextToken(tl);              /* "vmod_name" */
436 20
                vcc_NextToken(tl);              /* "as" */
437 20
                ExpectErr(tl, ID);              /* "vcl_name" */
438 20
        }
439 2468
        tmod = tl->t;
440
441 2468
        msym = VCC_SymbolGet(tl, SYM_MAIN, SYM_VMOD, SYMTAB_CREATE, XREF_NONE);
442 2468
        ERRCHK(tl);
443 2464
        AN(msym);
444
445 2464
        bprintf(fn, "libvmod_%.*s.so", PF(mod));
446 2464
        if (tl->t->tok == ID) {
447 20
                if (!vcc_IdIs(tl->t, "from")) {
448 4
                        VSB_cat(tl->sb, "Expected 'from path ...'\n");
449 4
                        vcc_ErrWhere(tl, tl->t);
450 4
                        return;
451
                }
452 16
                vcc_NextToken(tl);
453 16
                if (!tl->unsafe_path && strchr(tl->t->dec, '/')) {
454 4
                        VSB_cat(tl->sb,
455
                            "'import ... from path ...' is unsafe.\nAt:");
456 4
                        vcc_ErrToken(tl, tl->t);
457 4
                        vcc_ErrWhere(tl, tl->t);
458 4
                        return;
459
                }
460 12
                ExpectErr(tl, CSTR);
461 12
                p = strrchr(tl->t->dec, '/');
462 12
                if (p != NULL && p[1] == '\0')
463 4
                        bprintf(fn, "%slibvmod_%.*s.so", tl->t->dec, PF(mod));
464
                else
465 8
                        bprintf(fn, "%s", tl->t->dec);
466 12
                vcc_NextToken(tl);
467 12
        } else {
468 3060
                VTAILQ_FOREACH(vim, &imports, list) {
469 624
                        if (!vcc_IdIs(mod, vim->name))
470 604
                                continue;
471 20
                        if (!vim->unimported_vext)
472 12
                                continue;
473 8
                        fprintf(stderr, "IMPORT %s from VEXT\n", vim->name);
474 8
                        vim->unimported_vext = 0;
475 8
                        vim->t_mod = mod;
476 8
                        vim->sym = msym;
477 8
                        break;
478
                }
479
        }
480
481 2456
        SkipToken(tl, ';');
482
483 2456
        if (vim == NULL) {
484 2448
                ALLOC_OBJ(vim, VMOD_IMPORT_MAGIC);
485 2448
                AN(vim);
486 2448
                vim->t_mod = mod;
487 2448
                vim->sym = msym;
488
489 2448
                if (VFIL_searchpath(tl->vmod_path, vcc_path_open, vim, fn, &vim->path)) {
490 16
                        if (vim->err == NULL) {
491 8
                                VSB_printf(tl->sb,
492 4
                                    "Could not find VMOD %.*s\n", PF(mod));
493 4
                        } else {
494 24
                                VSB_printf(tl->sb,
495 12
                                    "Could not open VMOD %.*s\n", PF(mod));
496 24
                                VSB_printf(tl->sb, "\tFile name: %s\n",
497 12
                                    vim->path != NULL ? vim->path : fn);
498 12
                                VSB_printf(tl->sb, "\tError: %s\n", vim->err);
499
                        }
500 16
                        vcc_ErrWhere(tl, mod);
501 16
                        vcc_vim_destroy(&vim);
502 16
                        return;
503
                }
504
505 2432
                if (vcc_VmodLoad(tl, vim) < 0 || tl->err) {
506 44
                        vcc_ErrWhere(tl, vim->t_mod);
507 44
                        vcc_vim_destroy(&vim);
508 44
                        return;
509
                }
510 2388
        }
511
512 2396
        if (!vcc_IdIs(vim->t_mod, vim->name)) {
513 8
                vcc_ErrWhere(tl, vim->t_mod);
514 16
                VSB_printf(tl->sb, "Wrong file for VMOD %.*s\n",
515 8
                    PF(vim->t_mod));
516 8
                VSB_printf(tl->sb, "\tFile name: %s\n", vim->path);
517 8
                VSB_printf(tl->sb, "\tContains vmod \"%s\"\n", vim->name);
518 8
                vcc_vim_destroy(&vim);
519 8
                return;
520
        }
521
522 2388
        vimold = msym->import;
523 2388
        if (vimold != NULL) {
524 12
                CHECK_OBJ(vimold, VMOD_IMPORT_MAGIC);
525 12
                if (!vstrcmp(vimold->file_id, vim->file_id)) {
526
                        /* Identical import is OK */
527 8
                } else {
528 8
                        VSB_printf(tl->sb,
529
                            "Another module already imported as %.*s.\n",
530 4
                            PF(tmod));
531 4
                        vcc_ErrWhere2(tl, t1, tl->t);
532
                }
533 12
                vcc_vim_destroy(&vim);
534 12
                return;
535
        }
536 2376
        msym->def_b = t1;
537 2376
        msym->def_e = tl->t;
538
539 2960
        VTAILQ_FOREACH(vsym, &tl->sym_vmods, sideways) {
540 588
                assert(vsym->kind == SYM_VMOD);
541 588
                vimold = vsym->import;
542 588
                CHECK_OBJ_NOTNULL(vimold, VMOD_IMPORT_MAGIC);
543 588
                if (!vstrcmp(vimold->file_id, vim->file_id)) {
544
                        /* Already loaded under different name */
545 4
                        msym->eval_priv = vsym->eval_priv;
546 4
                        msym->import = vsym->import;
547 4
                        msym->vmod_name = vsym->vmod_name;
548 4
                        vcc_VmodSymbols(tl, msym);
549 4
                        AZ(tl->err);
550
                        // XXX: insert msym in sideways ?
551 4
                        vcc_vim_destroy(&vim);
552 4
                        return;
553
                }
554 584
        }
555
556 2372
        VTAILQ_INSERT_TAIL(&tl->sym_vmods, msym, sideways);
557
558 2372
        msym->eval_priv = vim->vj;
559 2372
        msym->import = vim;
560 2372
        msym->vmod_name = TlDup(tl, vim->name);
561 2372
        vcc_VmodSymbols(tl, msym);
562 2372
        ERRCHK(tl);
563
564 2368
        vcc_emit_setup(tl, vim);
565 2468
}
566
567
void
568 8
vcc_ImportVext(struct vcc *tl, const char *filename)
569
{
570
        struct vmod_import *vim;
571
572 8
        ALLOC_OBJ(vim, VMOD_IMPORT_MAGIC);
573 8
        AN(vim);
574
575 8
        if (vcc_Extract_JSON(vim, filename)) {
576 0
                FREE_OBJ(vim);
577 0
                return;
578
        }
579 8
        fprintf(stderr, "FOUND VMOD in VEXT %s\n", filename);
580 8
        if (vcc_VmodLoad(tl, vim) < 0 || tl->err) {
581
                // vcc_ErrWhere(tl, vim->t_mod);
582 0
                vcc_vim_destroy(&vim);
583 0
                return;
584
        }
585 8
        vim->from_vext = 1;
586 8
        vim->unimported_vext = 1;
587 8
        vim->path = strdup(filename);
588 8
        vim->path += 1;
589 8
        AN(vim->path);
590 8
        fprintf(stderr, "GOOD VMOD %s in VEXT %s\n", vim->name, filename);
591 8
}