From demontpx at gmail.com  Thu Mar 17 10:56:18 2016
From: demontpx at gmail.com (Bert Hekman)
Date: Thu, 17 Mar 2016 11:56:18 +0100
Subject: Pid filename incorrect and -j not allowed with 4.1 and ubuntu
Message-ID: <CAFiPH751gAV3dsJ=7owWDBy2ZQu+me9maew2in11wcWu6gjgeQ@mail.gmail.com>

Hi,

I've just installed varnish 4.1 on a ubuntu trusty server and noticed two
issues with the deb package.


The first is that the pidfile points to /run/.pid. I've found out that this
filename is generated in /etc/init.d/varnish:

PIDFILE=/run/$NAME.pid

$NAME does not seem to be defined.


The second issue is when I want to use the -j argument. I should be able to
configure this in /etc/default/varnish in the DAEMON_OPTS variable. But
when I start the daemon, it fails with the following message:

 * Starting HTTP accelerator varnish
   ...fail!
Error: -j must be the first argument

When I put the -j argument as the first argument in the DAEMON_OPTS, it
still fails. This is because in /etc/init.d/varnish "-P ${PIDFILE}" comes
before "${DAEMON_OPTS}"

Cheers,
Bert Hekman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/vinyl-dist/attachments/20160317/9d5f6e23/attachment.html>

From demontpx at gmail.com  Fri Mar 18 15:09:27 2016
From: demontpx at gmail.com (Bert Hekman)
Date: Fri, 18 Mar 2016 16:09:27 +0100
Subject: Pid filename incorrect and -j not allowed with 4.1 and ubuntu
In-Reply-To: <CAFiPH751gAV3dsJ=7owWDBy2ZQu+me9maew2in11wcWu6gjgeQ@mail.gmail.com>
References: <CAFiPH751gAV3dsJ=7owWDBy2ZQu+me9maew2in11wcWu6gjgeQ@mail.gmail.com>
Message-ID: <CAFiPH75kGCEtXkvJtekj6icAs+ToWUo15vqwJFX6Hcv0YzrfEA@mail.gmail.com>

Hi,

I figured out where I could make a pull request to to fix my issues on
github.

It seems that the first issue with the pidfile was already noticed by
someone else and they've made a pull request here:
https://github.com/varnishcache/pkg-varnish-cache/pull/16

I've made a pull request which fixes my second issue with the argument
order:
https://github.com/varnishcache/pkg-varnish-cache/pull/19

If they could be looked at, that would be sweet :)

Cheers,
Bert Hekman

2016-03-17 11:56 GMT+01:00 Bert Hekman <demontpx at gmail.com>:

> Hi,
>
> I've just installed varnish 4.1 on a ubuntu trusty server and noticed two
> issues with the deb package.
>
>
> The first is that the pidfile points to /run/.pid. I've found out that
> this filename is generated in /etc/init.d/varnish:
>
> PIDFILE=/run/$NAME.pid
>
> $NAME does not seem to be defined.
>
>
> The second issue is when I want to use the -j argument. I should be able
> to configure this in /etc/default/varnish in the DAEMON_OPTS variable. But
> when I start the daemon, it fails with the following message:
>
>  * Starting HTTP accelerator varnish
>    ...fail!
> Error: -j must be the first argument
>
> When I put the -j argument as the first argument in the DAEMON_OPTS, it
> still fails. This is because in /etc/init.d/varnish "-P ${PIDFILE}" comes
> before "${DAEMON_OPTS}"
>
> Cheers,
> Bert Hekman
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/vinyl-dist/attachments/20160318/69b7475b/attachment.html>