From n.leutner at all2e.com Mon Aug 3 12:47:00 2009 From: n.leutner at all2e.com (Norman Leutner) Date: Mon, 3 Aug 2009 14:47:00 +0200 Subject: Nagios monitoring Message-ID: <242AED17A878084BAA524EBD35F3CEFF2E5141E7@winxbede03.exchange.xchg> Hi, is there something already available like the munin monitoring plugin for nagios ? Greetings Norman Leutner -------------- next part -------------- An HTML attachment was scrubbed... URL: From ssm at redpill-linpro.com Mon Aug 3 13:41:15 2009 From: ssm at redpill-linpro.com (Stig Sandbeck Mathisen) Date: Mon, 03 Aug 2009 15:41:15 +0200 Subject: Nagios monitoring In-Reply-To: <242AED17A878084BAA524EBD35F3CEFF2E5141E7@winxbede03.exchange.xchg> (Norman Leutner's message of "Mon, 3 Aug 2009 14:47:00 +0200") References: <242AED17A878084BAA524EBD35F3CEFF2E5141E7@winxbede03.exchange.xchg> Message-ID: <7xab2hrp50.fsf@redpill-linpro.com> Norman Leutner writes: > Hi, > > is there something already available like the munin monitoring plugin > for nagios ? Looks like it, see http://varnish.projects.linpro.no/browser/trunk/varnish-tools/nagios -- Stig Sandbeck Mathisen Redpill Linpro AS - Changing the Game From n.leutner at all2e.com Mon Aug 3 14:59:30 2009 From: n.leutner at all2e.com (Norman Leutner) Date: Mon, 3 Aug 2009 16:59:30 +0200 Subject: AW: Nagios monitoring In-Reply-To: <7xab2hrp50.fsf@redpill-linpro.com> References: <242AED17A878084BAA524EBD35F3CEFF2E5141E7@winxbede03.exchange.xchg> <7xab2hrp50.fsf@redpill-linpro.com> Message-ID: <242AED17A878084BAA524EBD35F3CEFF2E51422B@winxbede03.exchange.xchg> Ah ok, haven't seen it... Thanks. Best regards Norman Leutner all2e GmbH Enterprise Content?Management http://www.all2e.com -----Urspr?ngliche Nachricht----- Von: Stig Sandbeck Mathisen [mailto:ssm at redpill-linpro.com] Gesendet: Montag, 3. August 2009 15:41 An: Norman Leutner Cc: varnish-dev at projects.linpro.no Betreff: Re: Nagios monitoring Norman Leutner writes: > Hi, > > is there something already available like the munin monitoring plugin > for nagios ? Looks like it, see http://varnish.projects.linpro.no/browser/trunk/varnish-tools/nagios -- Stig Sandbeck Mathisen Redpill Linpro AS - Changing the Game From tfheen at redpill-linpro.com Tue Aug 4 08:22:23 2009 From: tfheen at redpill-linpro.com (Tollef Fog Heen) Date: Tue, 04 Aug 2009 10:22:23 +0200 Subject: r4078 - trunk/varnish-cache/bin/varnishd In-Reply-To: <20090514113817.B94B41F7C2A@projects.linpro.no> (phk@projects.linpro.no's message of "Thu, 14 May 2009 13:38:17 +0200 (CEST)") References: <20090514113817.B94B41F7C2A@projects.linpro.no> Message-ID: <87ocqwq98g.fsf@qurzaw.linpro.no> ]] | Author: phk | Date: 2009-05-14 13:38:17 +0200 (Thu, 14 May 2009) | New Revision: 4078 | | Modified: | trunk/varnish-cache/bin/varnishd/mgt_cli.c | Log: | Don't show stats with zero value in cli. Won't this confuse monitoring applications which expect all the values to be there? I know at least there's an SNMP bridge (or what the term is?) which connects to the CLI and runs stats there. -- Tollef Fog Heen Redpill Linpro -- Changing the game! t: +47 21 54 41 73 From tfheen at redpill-linpro.com Tue Aug 4 08:35:05 2009 From: tfheen at redpill-linpro.com (Tollef Fog Heen) Date: Tue, 04 Aug 2009 10:35:05 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <20090606184243.DEB491F7BE3@projects.linpro.no> (des@projects.linpro.no's message of "Sat, 6 Jun 2009 20:42:43 +0200 (CEST)") References: <20090606184243.DEB491F7BE3@projects.linpro.no> Message-ID: <87k51kq8na.fsf@qurzaw.linpro.no> ]] | Author: des | Date: 2009-06-06 20:42:43 +0200 (Sat, 06 Jun 2009) | New Revision: 4097 | | Modified: | trunk/varnish-cache/lib/libvarnish/version.c | Log: | Forgot this one. (Url: http://varnish.projects.linpro.no/changeset/4097 ) This was useful in its own right, now trunk will report: > ./bin/varnishd/varnishd -V varnishd (varnish-trunk) Copyright (c) 2006-2009 Linpro AS / Verdens Gang AS which is not particularly useful. Previously, it would report the svn revision number as well. Can we revert 4097 and 4096, or would you rather implement it in another way? -- Tollef Fog Heen Redpill Linpro -- Changing the game! t: +47 21 54 41 73 From des at des.no Tue Aug 4 17:05:32 2009 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Tue, 04 Aug 2009 19:05:32 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <87k51kq8na.fsf@qurzaw.linpro.no> (Tollef Fog Heen's message of "Tue, 04 Aug 2009 10:35:05 +0200") References: <20090606184243.DEB491F7BE3@projects.linpro.no> <87k51kq8na.fsf@qurzaw.linpro.no> Message-ID: <861vnr33xf.fsf@ds4.des.no> Tollef Fog Heen writes: > which is not particularly useful. Previously, it would report the svn > revision number as well. Can we revert 4097 and 4096, or would you > rather implement it in another way? I sent you an email a long time ago explaining why this was wrong, and gave you adequate time to respond before I committed. Amongst other things, it breaks the build on non-GNU platforms, and it doesn't work with releases, source tarballs, or trees checked out with 'svn export' instead of 'svn co'. DES -- Dag-Erling Sm?rgrav - des at des.no From tfheen at redpill-linpro.com Wed Aug 5 09:12:51 2009 From: tfheen at redpill-linpro.com (Tollef Fog Heen) Date: Wed, 05 Aug 2009 11:12:51 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <861vnr33xf.fsf@ds4.des.no> ("Dag-Erling =?utf-8?Q?Sm=C3=B8rg?= =?utf-8?Q?rav=22's?= message of "Tue, 04 Aug 2009 19:05:32 +0200") References: <20090606184243.DEB491F7BE3@projects.linpro.no> <87k51kq8na.fsf@qurzaw.linpro.no> <861vnr33xf.fsf@ds4.des.no> Message-ID: <87my6ey67g.fsf@qurzaw.linpro.no> ]] Dag-Erling Sm?rgrav | Tollef Fog Heen writes: | > which is not particularly useful. Previously, it would report the svn | > revision number as well. Can we revert 4097 and 4096, or would you | > rather implement it in another way? | | I sent you an email a long time ago explaining why this was wrong, and | gave you adequate time to respond before I committed. Amongst other | things, it breaks the build on non-GNU platforms, This was fixed in r4014. | and it doesn't work with releases, source tarballs, or trees checked | out with 'svn export' instead of 'svn co'. Make distcheck disagrees with you. If you have a situation where it breaks, can you revert the merge locally and send me the build log? (Sure, it'll say: ?varnishd (varnish-trunk SVN eksportert)?, which is useless, but I don't see that as a reason to revert the merge, it's still useful in the case where people build from a checkout.) -- Tollef Fog Heen Redpill Linpro -- Changing the game! t: +47 21 54 41 73 From des at des.no Wed Aug 5 15:25:25 2009 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Wed, 05 Aug 2009 17:25:25 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <87my6ey67g.fsf@qurzaw.linpro.no> (Tollef Fog Heen's message of "Wed, 05 Aug 2009 11:12:51 +0200") References: <20090606184243.DEB491F7BE3@projects.linpro.no> <87k51kq8na.fsf@qurzaw.linpro.no> <861vnr33xf.fsf@ds4.des.no> <87my6ey67g.fsf@qurzaw.linpro.no> Message-ID: <86ocqu7062.fsf@ds4.des.no> Tollef Fog Heen writes: > Dag-Erling Sm?rgrav writes: > > I sent you an email a long time ago explaining why this was wrong, and > > gave you adequate time to respond before I committed. Amongst other > > things, it breaks the build on non-GNU platforms, > This was fixed in r4014. No, it's still broken (dependency tracking doesn't work properly). DES -- Dag-Erling Sm?rgrav - des at des.no From des at des.no Wed Aug 5 15:27:09 2009 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Wed, 05 Aug 2009 17:27:09 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <86ocqu7062.fsf@ds4.des.no> ("Dag-Erling =?utf-8?Q?Sm=C3=B8rg?= =?utf-8?Q?rav=22's?= message of "Wed, 05 Aug 2009 17:25:25 +0200") References: <20090606184243.DEB491F7BE3@projects.linpro.no> <87k51kq8na.fsf@qurzaw.linpro.no> <861vnr33xf.fsf@ds4.des.no> <87my6ey67g.fsf@qurzaw.linpro.no> <86ocqu7062.fsf@ds4.des.no> Message-ID: <86k51i7036.fsf@ds4.des.no> Dag-Erling Sm?rgrav writes: > Tollef Fog Heen writes: > > Dag-Erling Sm?rgrav writes: > > > I sent you an email a long time ago explaining why this was wrong, and > > > gave you adequate time to respond before I committed. Amongst other > > > things, it breaks the build on non-GNU platforms, > > This was fixed in r4014. > No, it's still broken (dependency tracking doesn't work properly). And I should have added: it provides incomplete information for builds from mixed trees (e.g. if one file has been rolled back to work around a bug). DES -- Dag-Erling Sm?rgrav - des at des.no From phk at phk.freebsd.dk Thu Aug 6 10:09:53 2009 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Thu, 06 Aug 2009 10:09:53 +0000 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: Your message of "Tue, 04 Aug 2009 19:05:32 +0200." <861vnr33xf.fsf@ds4.des.no> Message-ID: <2022.1249553393@critter.freebsd.dk> >I sent you an email a long time ago explaining why this was wrong, and >gave you adequate time to respond before I committed. Amongst other >things, it breaks the build on non-GNU platforms, and it doesn't work >with releases, source tarballs, or trees checked out with 'svn export' >instead of 'svn co'. I think we have to call a time-out on this one. I originally asked to have the SVN version in there, and if not exactly in those words, then by intention of "just like FreeBSD does it". I certainly don't run a GNU platform and I have not had problems with the code, so I would like it back, until a better solution, which will be very welcome, is offered. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk at FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From des at des.no Thu Aug 6 13:57:03 2009 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Thu, 06 Aug 2009 15:57:03 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <2022.1249553393@critter.freebsd.dk> (Poul-Henning Kamp's message of "Thu, 06 Aug 2009 10:09:53 +0000") References: <2022.1249553393@critter.freebsd.dk> Message-ID: <86r5vp6o5s.fsf@ds4.des.no> "Poul-Henning Kamp" writes: > I originally asked to have the SVN version in there, and if not exactly > in those words, then by intention of "just like FreeBSD does it". > > I certainly don't run a GNU platform and I have not had problems with > the code Take a closer look - unless you use GNU make, you'll see that it breaks dependency tracking for libvarnish, which, with the svnversion hack, is always considered dirty. > so I would like it back, until a better solution, which will be very > welcome, is offered. There is a better solution: the RCS ID of every source file is embedded in a string in the object, "just like FreeBSD does it". This is a better solution not only because it does not break dependency tracking, but because it is more detailed, and covers more than just libvarnish. DES -- Dag-Erling Sm?rgrav - des at des.no From phk at phk.freebsd.dk Thu Aug 6 14:12:59 2009 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Thu, 06 Aug 2009 14:12:59 +0000 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: Your message of "Thu, 06 Aug 2009 15:57:03 +0200." <86r5vp6o5s.fsf@ds4.des.no> Message-ID: <3061.1249567979@critter.freebsd.dk> In message <86r5vp6o5s.fsf at ds4.des.no>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= wr ites: >There is a better solution: the RCS ID of every source file is embedded >in a string in the object, "just like FreeBSD does it". This is a >better solution not only because it does not break dependency tracking, >but because it is more detailed, and covers more than just libvarnish. Provide a patch ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk at FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From des at des.no Thu Aug 6 14:15:36 2009 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Thu, 06 Aug 2009 16:15:36 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <3061.1249567979@critter.freebsd.dk> (Poul-Henning Kamp's message of "Thu, 06 Aug 2009 14:12:59 +0000") References: <3061.1249567979@critter.freebsd.dk> Message-ID: <864osl6nav.fsf@ds4.des.no> "Poul-Henning Kamp" writes: > "Dag-Erling Sm?rgrav" writes: > > There is a better solution: the RCS ID of every source file is embedded > > in a string in the object, "just like FreeBSD does it". This is a > > better solution not only because it does not break dependency tracking, > > but because it is more detailed, and covers more than just libvarnish. > Provide a patch ? I committed it two months ago (r4093 on 2009-06-06). DES -- Dag-Erling Sm?rgrav - des at des.no From phk at phk.freebsd.dk Thu Aug 6 14:58:09 2009 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Thu, 06 Aug 2009 14:58:09 +0000 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: Your message of "Thu, 06 Aug 2009 16:15:36 +0200." <864osl6nav.fsf@ds4.des.no> Message-ID: <3180.1249570689@critter.freebsd.dk> In message <864osl6nav.fsf at ds4.des.no>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= wr ites: >"Poul-Henning Kamp" writes: >> "Dag-Erling Sm=C3=B8rgrav" writes: >> > There is a better solution: the RCS ID of every source file is embedded >> > in a string in the object, "just like FreeBSD does it". This is a >> > better solution not only because it does not break dependency tracking, >> > but because it is more detailed, and covers more than just libvarnish. >> Provide a patch ? > >I committed it two months ago (r4093 on 2009-06-06). This is nice, and we should have that, _as well_, for people like sky@ who muck about with their own branch. But it is no substitute for a tree-wide version number, and the two schemes are in no way conflicting or in each others way. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk at FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From des at des.no Thu Aug 6 15:30:05 2009 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Thu, 06 Aug 2009 17:30:05 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <3180.1249570689@critter.freebsd.dk> (Poul-Henning Kamp's message of "Thu, 06 Aug 2009 14:58:09 +0000") References: <3180.1249570689@critter.freebsd.dk> Message-ID: <86ocqt55aa.fsf@ds4.des.no> "Poul-Henning Kamp" writes: > This is nice, and we should have that, _as well_, for people like > sky@ who muck about with their own branch. > > But it is no substitute for a tree-wide version number, and the > two schemes are in no way conflicting or in each others way. There is no such thing. It's a sham. What Tollef's patch does is fill in a string with a fictitious value which may or may not be related in some way to the actual version of one or more of the files in libvarnish in some sort of RCS which may or may not be the official repo. Git hashes, for instance, have meaning only in the context of the specific git tree from which Varnish was built, and the way git works, every user has their own tree. DES -- Dag-Erling Sm?rgrav - des at des.no From phk at phk.freebsd.dk Thu Aug 6 21:14:59 2009 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Thu, 06 Aug 2009 21:14:59 +0000 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: Your message of "Thu, 06 Aug 2009 17:30:05 +0200." <86ocqt55aa.fsf@ds4.des.no> Message-ID: <3946.1249593299@critter.freebsd.dk> In message <86ocqt55aa.fsf at ds4.des.no>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= wr ites: >"Poul-Henning Kamp" writes: >> This is nice, and we should have that, _as well_, for people like >> sky@ who muck about with their own branch. >> >> But it is no substitute for a tree-wide version number, and the >> two schemes are in no way conflicting or in each others way. > >There is no such thing. It's a sham. No, it is not a sham, for a very large majority of users, it is indeed plenty to allow me to figure which version they are running. Anyway, if you don't like it, don't use it. I like it, I use it. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk at FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From tfheen at redpill-linpro.com Fri Aug 7 06:35:21 2009 From: tfheen at redpill-linpro.com (Tollef Fog Heen) Date: Fri, 07 Aug 2009 08:35:21 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <86r5vp6o5s.fsf@ds4.des.no> ("Dag-Erling =?utf-8?Q?Sm=C3=B8rg?= =?utf-8?Q?rav=22's?= message of "Thu, 06 Aug 2009 15:57:03 +0200") References: <2022.1249553393@critter.freebsd.dk> <86r5vp6o5s.fsf@ds4.des.no> Message-ID: <87k51gm8ra.fsf@qurzaw.linpro.no> ]] Dag-Erling Sm?rgrav | There is a better solution: the RCS ID of every source file is embedded | in a string in the object, "just like FreeBSD does it". This is a | better solution not only because it does not break dependency tracking, | but because it is more detailed, and covers more than just libvarnish. Take a look at sys/conf/newvers.sh, particularly line 102 and onwards in the FreeBSD source tree. What I'm trying to do is something along the lines of that bit. If you have suggestions on improving how my implementation works, I'm happy to hear those (or have patches applied). -- Tollef Fog Heen Redpill Linpro -- Changing the game! t: +47 21 54 41 73 From des at des.no Fri Aug 7 13:16:37 2009 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Fri, 07 Aug 2009 15:16:37 +0200 Subject: r4097 - trunk/varnish-cache/lib/libvarnish In-Reply-To: <87k51gm8ra.fsf@qurzaw.linpro.no> (Tollef Fog Heen's message of "Fri, 07 Aug 2009 08:35:21 +0200") References: <2022.1249553393@critter.freebsd.dk> <86r5vp6o5s.fsf@ds4.des.no> <87k51gm8ra.fsf@qurzaw.linpro.no> Message-ID: <86k51frcga.fsf@ds4.des.no> Tollef Fog Heen writes: > Dag-Erling Sm?rgrav writes: > > There is a better solution: the RCS ID of every source file is embedded > > in a string in the object, "just like FreeBSD does it". This is a > > better solution not only because it does not break dependency tracking, > > but because it is more detailed, and covers more than just libvarnish. > Take a look at sys/conf/newvers.sh, particularly line 102 and onwards in > the FreeBSD source tree. What I'm trying to do is something along the > lines of that bit. If you have suggestions on improving how my > implementation works, I'm happy to hear those (or have patches applied). I already committed a patch - two months ago - which implements the solution described above. For the record, I objected to FreeBSD's svnversion hack when phk committed it, for [some of] the same reasons I object to this one. DES -- Dag-Erling Sm?rgrav - des at des.no From bernard at sprybts.com Wed Aug 12 08:02:07 2009 From: bernard at sprybts.com (Bernard Gardner) Date: Wed, 12 Aug 2009 18:02:07 +1000 Subject: test b00007.vtc (intermittently) failing on varnish-2.0.4 Message-ID: Hi, I'm completely new to varnish, other than having been reading about it for a while and wishing I had the time to implement it for a particular client for the last 6 months or so. Their web performance issues have now become so bad that I suddenly have the time. I've just downloaded the varnish 2.0.4 tarball from sourceforge and attempted to build an RPM from it (extracted the spec file to SPECS and copied the .tar.gz file to my SOURCES directory then used rpmbuild -ba varnish.spec). In the copious test output I had a failure of one of the tests, detailed below. You asked for a report, so here it is. # top TEST ././tests/b00007.vtc starting # TEST Check chunked encoding from backend works ## s1 Starting server ### s1 listen on 127.0.0.1:9090 (fd 3) ## v1 Launch ### v1 CMD: cd ../varnishd && ./varnishd -d -d -n /tmp/__v1 -a '127.0.0.1:9091' -T 127.0.0.1:9011 -P /tmp/__v1/varnishd.pid ### v1 opening CLI connection ## s1 Started on 127.0.0.1:9090 ### v1 CLI connection fd = 4 Assert error in varnish_ask_cli(), vtc_varnish.c line 100: Condition(i == 0) not true. errno = 110 (Connection timed out) /bin/sh: line 1: 8624 Aborted ./varnishtest ${dir}$tst FAIL: ./tests/b00007.vtc [...] =============================================== 1 of 130 tests failed Please report to varnish-dev at projects.linpro.no =============================================== make[3]: *** [check-TESTS] Error 1 make[3]: Leaving directory `/usr/src/redhat/BUILD/varnish-2.0.4/bin/ varnishtest' make[2]: *** [check-am] Error 2 make[2]: Leaving directory `/usr/src/redhat/BUILD/varnish-2.0.4/bin/ varnishtest' make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory `/usr/src/redhat/BUILD/varnish-2.0.4/bin' make: *** [check-recursive] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.17064 (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.17064 (%check) This is on a CentOS 4.4 x86_64 virtual server (vmware) which we use for builds for all of the code this client runs. Other than the failed test, I can't see any errors or warnings in the build output. To rule out a cosmic ray strike, I re-ran the rpmbuild and the second time through got a clean bill of health - I'll leave it to you guys to decide if it was indeed a cosmic ray strike or if there's perhaps an intermittent issue with chunked encoding. I'm pretty sure I didn't change anything on the system between the two build attempts and the second run was from my shell history so they were as alike as I could make them. BTW - the spec file doesn't clean up BUILD/varnish-2.0.4 after itself. Now to see if I can replicate their current load balancer config in vcl... Thanks, Bernard. -- Bernard Gardner Spry Business Technology Solutions Pty. Ltd. http://www.sprybts.com/ PO Box 860, Strawberry Hills, NSW 2012, AUSTRALIA From jos at dwim.org Thu Aug 20 18:12:41 2009 From: jos at dwim.org (Jos I. Boumans) Date: Thu, 20 Aug 2009 18:12:41 -0000 Subject: [PATCH] Fix typo in esi diagnostic Message-ID: <591B5DF8-A755-40F2-9677-BE0D3614F6F8@dwim.org> Greetings, While browsing the source, I came a cross a small typo. Patch below sig. Cheers, -- Jos Boumans "Whenever you find you are on the side of the majority, it is time to pause and reflect." - Mark Twain Index: varnish-cache/bin/varnishd/cache_esi.c =================================================================== --- varnish-cache/bin/varnishd/cache_esi.c (revision 4207) +++ varnish-cache/bin/varnishd/cache_esi.c (working copy) @@ -370,7 +370,7 @@ continue; if (Tlen(val) == 0) { esi_error(ew, tag.b, Tlen(tag), - "ESI esi:include src attribute withou value"); + "ESI esi:include src attribute without value"); continue; }