From varnish-bugs at varnish-cache.org Tue Aug 5 10:16:41 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 10:16:41 -0000 Subject: [Varnish] #1557: regsuball() doesn't honor lookahead assertion on repeated strings In-Reply-To: <059.714287d6d2b95c176d62f92faff8648e@varnish-cache.org> References: <059.714287d6d2b95c176d62f92faff8648e@varnish-cache.org> Message-ID: <074.1c3eccb9e853314da029eb076ac86cbb@varnish-cache.org> #1557: regsuball() doesn't honor lookahead assertion on repeated strings --------------------------------------+--------------------- Reporter: varnish@? | Owner: tfheen Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: normal | Resolution: Keywords: lookahead pcre regsuball | --------------------------------------+--------------------- Changes (by fgsch): * owner: => tfheen -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 10:22:05 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 10:22:05 -0000 Subject: [Varnish] #1559: Panic: Assert error in Lck__Lock(), cache/cache_lck.c line 70: Condition(((ilck))->magic == (0x7b86c8a5)) not true. In-Reply-To: <048.7a9165bdfc48fb046161cf45781b760a@varnish-cache.org> References: <048.7a9165bdfc48fb046161cf45781b760a@varnish-cache.org> Message-ID: <063.ed6aff86be8e8b65e1fcd3c881d259f8@varnish-cache.org> #1559: Panic: Assert error in Lck__Lock(), cache/cache_lck.c line 70: Condition(((ilck))->magic == (0x7b86c8a5)) not true. -----------------------------+-------------------- Reporter: esfourteen | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: panic, lck_lock | -----------------------------+-------------------- Comment (by slink): We believe you had been experiencing the issue fixed in b2b6e329da78e465720bec9a26a905e8a77cab92 -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 10:22:19 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 10:22:19 -0000 Subject: [Varnish] #1559: Panic: Assert error in Lck__Lock(), cache/cache_lck.c line 70: Condition(((ilck))->magic == (0x7b86c8a5)) not true. In-Reply-To: <048.7a9165bdfc48fb046161cf45781b760a@varnish-cache.org> References: <048.7a9165bdfc48fb046161cf45781b760a@varnish-cache.org> Message-ID: <063.dc1f7f3daabf4deb50a3d4cff9e69932@varnish-cache.org> #1559: Panic: Assert error in Lck__Lock(), cache/cache_lck.c line 70: Condition(((ilck))->magic == (0x7b86c8a5)) not true. -----------------------------+--------------------- Reporter: esfourteen | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: panic, lck_lock | -----------------------------+--------------------- Changes (by slink): * status: new => closed * resolution: => fixed -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 10:30:12 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 10:30:12 -0000 Subject: [Varnish] #1559: Panic: Assert error in Lck__Lock(), cache/cache_lck.c line 70: Condition(((ilck))->magic == (0x7b86c8a5)) not true. In-Reply-To: <048.7a9165bdfc48fb046161cf45781b760a@varnish-cache.org> References: <048.7a9165bdfc48fb046161cf45781b760a@varnish-cache.org> Message-ID: <063.5eed29952401b326f00d140b1d70af44@varnish-cache.org> #1559: Panic: Assert error in Lck__Lock(), cache/cache_lck.c line 70: Condition(((ilck))->magic == (0x7b86c8a5)) not true. -----------------------------+--------------------- Reporter: esfourteen | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: panic, lck_lock | -----------------------------+--------------------- Comment (by slink): the will will be in the next 4.0.x release -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 14:33:40 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 14:33:40 -0000 Subject: [Varnish] #1542: Child (21196) Panic message:#012Assert error in Lck__Lock(), cache/cache_lck.c line 70 In-Reply-To: <047.f514766cb40ad2ae55372f101be48ab1@varnish-cache.org> References: <047.f514766cb40ad2ae55372f101be48ab1@varnish-cache.org> Message-ID: <062.1f95319ba756586ff74f3ff43e8776e6@varnish-cache.org> #1542: Child (21196) Panic message:#012Assert error in Lck__Lock(), cache/cache_lck.c line 70 -----------------------+---------------------------------- Reporter: cmartinez | Owner: Type: defect | Status: closed Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: 4.0.1 Severity: critical | Resolution: duplicate Keywords: | -----------------------+---------------------------------- Changes (by slink): * status: new => closed * resolution: => duplicate -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 14:34:03 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 14:34:03 -0000 Subject: [Varnish] #1542: Child (21196) Panic message:#012Assert error in Lck__Lock(), cache/cache_lck.c line 70 In-Reply-To: <047.f514766cb40ad2ae55372f101be48ab1@varnish-cache.org> References: <047.f514766cb40ad2ae55372f101be48ab1@varnish-cache.org> Message-ID: <062.a9cc38eb98074ea5a1e38a2717004f73@varnish-cache.org> #1542: Child (21196) Panic message:#012Assert error in Lck__Lock(), cache/cache_lck.c line 70 -----------------------+---------------------------------- Reporter: cmartinez | Owner: Type: defect | Status: closed Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: 4.0.1 Severity: critical | Resolution: duplicate Keywords: | -----------------------+---------------------------------- Comment (by slink): should be the same as #1559 -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 14:42:15 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 14:42:15 -0000 Subject: [Varnish] #1544: segfault at 40 error 4 in varnishd In-Reply-To: <049.7736650ccfff554fe37de96b015b88fc@varnish-cache.org> References: <049.7736650ccfff554fe37de96b015b88fc@varnish-cache.org> Message-ID: <064.59d8062b3bfba55fbda409d67a632af3@varnish-cache.org> #1544: segfault at 40 error 4 in varnishd -------------------------+----------------------- Reporter: g.gerritsen | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | -------------------------+----------------------- Changes (by fgsch): * status: new => needinfo Comment: Are you still experiencing this? If so can you please provide some more details? OS, VCL and crash details at the very least. See https://www.varnish-cache.org/trac/wiki/DebuggingVarnish. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 14:47:30 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 14:47:30 -0000 Subject: [Varnish] #1543: Panic message: Assert error in Lck_Delete(), cache/cache_lck.c line 198 In-Reply-To: <047.3f011ce053d5cbd53e3230c73f3d7a63@varnish-cache.org> References: <047.3f011ce053d5cbd53e3230c73f3d7a63@varnish-cache.org> Message-ID: <062.2ca64852b6ae286f79c1f231a27625bf@varnish-cache.org> #1543: Panic message: Assert error in Lck_Delete(), cache/cache_lck.c line 198 -----------------------+---------------------------------- Reporter: WhizzBANG | Owner: Type: defect | Status: closed Priority: high | Milestone: Varnish 4.0 release Component: varnishd | Version: 4.0.1 Severity: blocker | Resolution: fixed Keywords: | -----------------------+---------------------------------- Changes (by fgsch): * status: needinfo => closed * resolution: => fixed Comment: No response after 3 weeks. This should be fixed in trunk and included in next release. If you are still experiencing issues please re-open it or raise a new ticket. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 19:50:53 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 19:50:53 -0000 Subject: [Varnish] #1565: Panic in VDP_gunzip Message-ID: <050.f3460a21745d7d66ca84d6a7a744c903@varnish-cache.org> #1565: Panic in VDP_gunzip ---------------------------+---------------------- Reporter: mattrobenolt | Type: defect Status: new | Priority: normal Milestone: | Component: varnishd Version: 4.0.1 | Severity: normal Keywords: panic, gunzip | ---------------------------+---------------------- {{{ varnish> panic.show 200 Last panic at: Tue, 05 Aug 2014 04:00:36 GMT Assert error in VDP_gunzip(), cache/cache_gzip.c line 303: Condition((act > VDP_NULL) != 0) not true. thread = (cache-worker) ident = Linux,3.13.0-32-generic,x86_64,-smalloc,-smalloc,-hcritbit,epoll Backtrace: 0x432e45: /usr/sbin/varnishd() [0x432e45] 0x423862: /usr/sbin/varnishd(VDP_gunzip+0x252) [0x423862] 0x439ab5: /usr/sbin/varnishd() [0x439ab5] 0x43a131: /usr/sbin/varnishd(V1D_Deliver+0x371) [0x43a131] 0x436ed0: /usr/sbin/varnishd(CNT_Request+0x3a0) [0x436ed0] 0x42cfab: /usr/sbin/varnishd(HTTP1_Session+0x3eb) [0x42cfab] 0x43b3c8: /usr/sbin/varnishd() [0x43b3c8] 0x435d50: /usr/sbin/varnishd(Pool_Work_Thread+0x370) [0x435d50] 0x448868: /usr/sbin/varnishd() [0x448868] 0x7fda1c410e9a: /lib/x86_64-linux-gnu/libpthread.so.0(+0x7e9a) [0x7fda1c410e9a] req = 0x7fd84f8c3020 { sp = 0x7fd82b676360, vxid = 1401142530, step = R_STP_DELIVER, req_body = R_BODY_NONE, restarts = 0, esi_level = 0 sp = 0x7fd82b676360 { fd = 124, vxid = 327635485, client = 23.235.46.35 64005, step = S_STP_WORKING, }, worker = 0x7fd6c699ac20 { ws = 0x7fd6c699ae38 { id = "wrk", {s,f,r,e} = {0x7fd6c699a410,+88,+2048,+2048}, }, VCL::method = 0x0, VCL::return = deliver, }, ws = 0x7fd84f8c31b8 { id = "req", {s,f,r,e} = {0x7fd84f8c5010,+856,(nil),+57360}, }, http[req] = { ws = 0x7fd84f8c31b8[req] "GET", "/combination_widget.js?color=blue&default_tab=popular&excerpt_length=200&hide_mods=0&num_items=100", "HTTP/1.1", "User-Agent: Python-urllib/2.7", "Fastly-Client-IP: 38.118.71.246", "X-Timer: S1407211235.044013,VS0", "Host: govexec.disqus.com", "X-Forwarded-Proto: http", "Disqus-Subdomain: 1", "X-Varnish: 2655587737", "X-Varnish: 2402991002", "Fastly-Client: 1", "Fastly-FF: cache-iad2133-IAD, cache-iad2135-IAD", "X-Forwarded-For: 38.118.71.246, 23.235.46.35", "Disqus-Local: 1", }, http[resp] = { ws = 0x7fd84f8c31b8[req] "HTTP/1.1", "200", "OK", "Server: nginx", "Date: Tue, 05 Aug 2014 03:45:34 GMT", "Content-Type: application/javascript; charset=UTF-8", "Vary: Accept-Encoding", "X-Frame-Options: SAMEORIGIN", "p3p: CP="DSP IDC CUR ADM DELi STP NAV COM UNI INT PHY DEM"", "Cache-Control: stale-while-revalidate=3600, public, max-age=600", "X-Content-Type-Options: nosniff", "X-XSS-Protection: 1; mode=block", "X-Backend: embed", "Surrogate-Grace: 3600s", "X-Varnish: 327400706 325658885", "Age: 901", "Via: 1.1 varnish-v4", "X-Served-By: app-172.dal05, shield-2.dal05", "X-Cache: MISS, HIT", "X-Cache-Hits: 0, 89", "Transfer-Encoding: chunked", "Connection: keep-alive", "Accept-Ranges: bytes", }, vcl = { srcname = { "input", "Builtin", "includes/4.0/recv-common.vcl", "includes/downgrade.vcl", "includes/grace.vcl", "includes/4.0/health-synthetic.vcl", "includes/x-served-by.vcl", }, }, obj (REQ) = 0x7fd82dd7cb00 { vxid = 2473142533, http[obj] = { ws = 0x7fd9fca75268[] "HTTP/1.1", "200", "OK", "Server: nginx", "Date: Tue, 05 Aug 2014 03:45:34 GMT", "Content-Type: application/javascript; charset=UTF-8", "Vary: Accept-Encoding", "X-Frame-Options: SAMEORIGIN", "p3p: CP="DSP IDC CUR ADM DELi STP NAV COM UNI INT PHY DEM"", "Cache-Control: stale-while-revalidate=3600, public, max-age=600", "X-Served-By: app-172.dal05", "X-Cache: MISS", "X-Cache-Hits: 0", "X-Content-Type-Options: nosniff", "X-XSS-Protection: 1; mode=block", "Content-Encoding: gzip", "X-Backend: embed", "Surrogate-Grace: 3600s", }, len = 8192, store = { 4096 { 1f 8b 08 00 00 00 00 00 00 03 ed 5d fb 72 d3 58 |...........].r.X| 9a ff 7b 78 8a b3 66 ab 81 d9 c8 b2 6c cb 97 00 |..{x..f.....l...| a1 92 40 d2 a1 81 64 92 40 96 29 aa 28 59 3a b6 |.. at ...d.@.).(Y:.| 45 64 c9 ad 23 c7 f1 74 4d d5 3c c6 ee eb cd 93 |Ed..#..tM.<.....| [4032 more] }, 4096 { ba fc f2 44 90 5b d9 45 bc c2 63 88 a5 61 28 d5 |...D.[.E..c..a(.| 45 cb b8 ca ae 10 96 03 c5 cd 41 ef b2 9e f4 45 |E.........A....E| 87 3d 86 b6 a3 8e a4 40 58 eb 10 42 47 67 47 67 |.=..... at X..BGgGg| 24 8c 04 47 8f 47 38 35 10 ad 84 e6 8f 1f ce 46 |$..G.G85.......F| [4032 more] }, 0 { }, }, }, }, }}} I'd be happy to provide whatever more information you need. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 21:04:44 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 21:04:44 -0000 Subject: [Varnish] #1565: Panic in VDP_gunzip In-Reply-To: <050.f3460a21745d7d66ca84d6a7a744c903@varnish-cache.org> References: <050.f3460a21745d7d66ca84d6a7a744c903@varnish-cache.org> Message-ID: <065.a46c8474a19638154a89587121990fcf@varnish-cache.org> #1565: Panic in VDP_gunzip ---------------------------+------------------------ Reporter: mattrobenolt | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: duplicate Keywords: panic, gunzip | ---------------------------+------------------------ Changes (by slink): * status: new => closed * resolution: => duplicate Comment: this looks exactly like #1561. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 21:07:28 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 21:07:28 -0000 Subject: [Varnish] #1565: Panic in VDP_gunzip In-Reply-To: <050.f3460a21745d7d66ca84d6a7a744c903@varnish-cache.org> References: <050.f3460a21745d7d66ca84d6a7a744c903@varnish-cache.org> Message-ID: <065.bcaf974ed70d36d71758464d9587ec61@varnish-cache.org> #1565: Panic in VDP_gunzip ---------------------------+------------------------ Reporter: mattrobenolt | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: duplicate Keywords: panic, gunzip | ---------------------------+------------------------ Comment (by mattrobenolt): Oh, neat, yeah, that looks the same. Any plans for 4.0.2 soonish? This is happening for us daily, so kind of a big deal. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 5 21:19:12 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 05 Aug 2014 21:19:12 -0000 Subject: [Varnish] #1565: Panic in VDP_gunzip In-Reply-To: <050.f3460a21745d7d66ca84d6a7a744c903@varnish-cache.org> References: <050.f3460a21745d7d66ca84d6a7a744c903@varnish-cache.org> Message-ID: <065.359a444eec5b4ca0560831cf9e1b430e@varnish-cache.org> #1565: Panic in VDP_gunzip ---------------------------+------------------------ Reporter: mattrobenolt | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: duplicate Keywords: panic, gunzip | ---------------------------+------------------------ Comment (by slink): Yes, 4.0.2 is planned "soonish". If this hits you, I'd recommend to just build from master. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 6 14:07:42 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 06 Aug 2014 14:07:42 -0000 Subject: [Varnish] #1566: escape sequence breaks regex Message-ID: <048.96582f05e1f84174e2f554fa6d8ea786@varnish-cache.org> #1566: escape sequence breaks regex ------------------------+-------------------- Reporter: RWOverdijk | Type: defect Status: new | Priority: normal Milestone: | Component: build Version: unknown | Severity: normal Keywords: | ------------------------+-------------------- This replace (routine vcl_fetch) breaks varnish: {{{ set req.url = regsuball(req.url, "\??(p|pi)=.*?(&|$)", ""); }}} Here's the error: {{{ varnishification at varisification:/etc/varnish$ sudo service varnish restart * Stopping HTTP accelerator varnishd [fail] * Starting HTTP accelerator varnishd [fail] Message from C-compiler: ./vcl.3F4sQ4FV.c: In function ?VGC_Init?: ./vcl.3F4sQ4FV.c:1264:28: error: trigraph ??( ignored, use -trigraphs to enable [-Werror=trigraphs] VRT_re_init(&VGC_re_3, "\\??(p|pi)=.*?(&|$)"); ^ ./vcl.3F4sQ4FV.c: At top level: ./vcl.3F4sQ4FV.c:1355:42: error: trigraph ??( ignored, use -trigraphs to enable [-Werror=trigraphs] " set req.url = regsuball(req.url, \"\\??(p|pi)=.*?(&|$)\", \"\");\n" ^ cc1: all warnings being treated as errors Running C-compiler failed, exit 1 VCL compilation failed }}} In my opinion this is a bug. It's a string, and the official language being communicated to users is VCL, not C. So, varnish should probably escape this escape sequence. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 6 17:29:52 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 06 Aug 2014 17:29:52 -0000 Subject: [Varnish] #1532: Incorrect representation when using reals In-Reply-To: <043.a249b8fcc6010c4373cabb40f415c46e@varnish-cache.org> References: <043.a249b8fcc6010c4373cabb40f415c46e@varnish-cache.org> Message-ID: <058.f936367fffa0fa45e810e7a5f00ebbb1@varnish-cache.org> #1532: Incorrect representation when using reals ----------------------+--------------------------------------------- Reporter: fgsch | Owner: Federico G. Schwindt Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: normal | Resolution: fixed Keywords: | ----------------------+--------------------------------------------- Comment (by Federico G. Schwindt ): In [9ea22d7800839d172926ddd55aa04d0e2816e394]: {{{ #!CommitTicketReference repository="" revision="9ea22d7800839d172926ddd55aa04d0e2816e394" Fix incorrect representation when using reals Fixes #1532 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 6 17:29:52 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 06 Aug 2014 17:29:52 -0000 Subject: [Varnish] #1531: varnishadm libedit does not clean command line In-Reply-To: <046.51a6851cfde1284fd5dd42c1f2fa15d3@varnish-cache.org> References: <046.51a6851cfde1284fd5dd42c1f2fa15d3@varnish-cache.org> Message-ID: <061.a5f956f27decfc8bc3d6e273e4cf0d9f@varnish-cache.org> #1531: varnishadm libedit does not clean command line ------------------------+--------------------------------------------- Reporter: lkarsten | Owner: Federico G. Schwindt Type: defect | Status: closed Priority: normal | Milestone: Component: varnishadm | Version: trunk Severity: normal | Resolution: fixed Keywords: | ------------------------+--------------------------------------------- Comment (by Federico G. Schwindt ): In [455281a9eff278f831de26644fd08c21528667a1]: {{{ #!CommitTicketReference repository="" revision="455281a9eff278f831de26644fd08c21528667a1" Workaround a problem in recent libedit versions Reinstall the readline handler when we are called in order to clear the input line. Tested in a variety of versions by scn and myself. Fixes #1531 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 7 00:58:15 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 07 Aug 2014 00:58:15 -0000 Subject: =?utf-8?q?=5BVarnish=5D_=231567=3A_error=3A_unused_variable_?= =?utf-8?b?4oCYdHbigJkgYXQgY2FjaGVfYWNjZXB0b3IuYyBhdCBjb21waWxh?= =?utf-8?q?tion_time_=28Solaris_and_Cygwin=29?= Message-ID: <043.22f815a5f6d390bb075af3de6a0aa869@varnish-cache.org> #1567: error: unused variable ?tv? at cache_acceptor.c at compilation time (Solaris and Cygwin) -------------------+-------------------- Reporter: jdzst | Type: defect Status: new | Priority: normal Milestone: | Component: build Version: 4.0.1 | Severity: normal Keywords: | -------------------+-------------------- If SO_SNDTIMEO_WORKS or SO_RCVTIMEO_WORKS is not defined the following error is thrown at compilation time: {{{ make[3]: Entering directory '/usr/src/varnish-4.0.1-1.i686/build/bin/varnishd' CC varnishd-cache_acceptor.o /usr/src/varnish-4.0.1-1.i686/src/varnish-4.0.1/bin/varnishd/cache/cache_acceptor.c: In function ?vca_tcp_opt_init?: /usr/src/varnish-4.0.1-1.i686/src/varnish-4.0.1/bin/varnishd/cache/cache_acceptor.c:131:17: error: unused variable ?tv? [-Werror=unused-variable] struct timeval tv; ^ cc1: all warnings being treated as errors Makefile:775: recipe for target 'varnishd-cache_acceptor.o' failed make[3]: *** [varnishd-cache_acceptor.o] Error 1 make[3]: Leaving directory '/usr/src/varnish-4.0.1-1.i686/build/bin/varnishd' Makefile:392: recipe for target 'all-recursive' failed make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory '/usr/src/varnish-4.0.1-1.i686/build/bin' Makefile:524: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/usr/src/varnish-4.0.1-1.i686/build' Makefile:409: recipe for target 'all' failed make: *** [all] Error 2 }}} This issue is only reproduced at Solaris and Cygwin platforms, where SO_SNDTIMEO_WORKS and SO_RCVTIMEO_WORKS are not defined. The solution is trivial, adding a #if defined, solves the issue: {{{ --- origsrc/varnish-4.0.0/bin/varnishd/cache/cache_acceptor.c 2014-04-10 11:19:18.000000000 +0200 +++ src/varnish-4.0.0/bin/varnishd/cache/cache_acceptor.c 2014-05-09 02:46:49.537264500 +0200 @@ -128,7 +128,9 @@ vca_tcp_opt_init(void) int one = 1; // int zero = 0; struct tcp_opt *to; +#if defined(SO_SNDTIMEO_WORKS) || defined(SO_RCVTIMEO_WORKS) struct timeval tv; +#endif int chg = 0; #ifdef HAVE_TCP_KEEP int x; }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 7 13:12:35 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 07 Aug 2014 13:12:35 -0000 Subject: [Varnish] #1568: director.hash with req.http.Cookie && empty req.http.Cookie results in SIGSEGV Message-ID: <046.f62a984b7424f6d73a1a93d957d4563d@varnish-cache.org> #1568: director.hash with req.http.Cookie && empty req.http.Cookie results in SIGSEGV ------------------------------------+---------------------- Reporter: zviratko | Type: defect Status: new | Priority: normal Milestone: Varnish 4.0 release | Component: varnishd Version: 4.0.1 | Severity: normal Keywords: segfault hash director | ------------------------------------+---------------------- If req.http.Cookie is empty and you are using it as a key for hash director, request results in SIGSEGV of the varnishd process. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 7 13:15:04 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 07 Aug 2014 13:15:04 -0000 Subject: [Varnish] #1569: having a subroutine named the same as backend results in Symbol not found Message-ID: <046.b47c55eccca631613556802863c1030c@varnish-cache.org> #1569: having a subroutine named the same as backend results in Symbol not found ---------------------------------+---------------------- Reporter: zviratko | Type: defect Status: new | Priority: normal Milestone: Varnish 4.0 release | Component: varnishd Version: 4.0.1 | Severity: normal Keywords: | ---------------------------------+---------------------- 1) define backend aaa 2) define sub aaa 3) set req.backend_hint = aaa; Results in: Symbol not found: 'aaa' (expected type BACKEND): -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 7 13:16:51 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 07 Aug 2014 13:16:51 -0000 Subject: [Varnish] #1570: varnish should handle unused backends and subroutines Message-ID: <046.607dd323bd0e0c622ad60b5583e3e76e@varnish-cache.org> #1570: varnish should handle unused backends and subroutines ----------------------+------------------------- Reporter: zviratko | Type: enhancement Status: new | Priority: normal Milestone: | Component: varnishd Version: unknown | Severity: normal Keywords: | ----------------------+------------------------- If backend is defined but unused or if sub is defined but unused, compilation error occurs I think this should be only a warning because it is a huge PITA for complex configurations when enabling/disabling features -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 7 16:02:13 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 07 Aug 2014 16:02:13 -0000 Subject: [Varnish] #1570: varnish should handle unused backends and subroutines In-Reply-To: <046.607dd323bd0e0c622ad60b5583e3e76e@varnish-cache.org> References: <046.607dd323bd0e0c622ad60b5583e3e76e@varnish-cache.org> Message-ID: <061.899df2092ec9c323c0267bfd95a7b0a3@varnish-cache.org> #1570: varnish should handle unused backends and subroutines -------------------------+---------------------- Reporter: zviratko | Owner: Type: enhancement | Status: closed Priority: normal | Milestone: Component: varnishd | Version: unknown Severity: normal | Resolution: invalid Keywords: | -------------------------+---------------------- Changes (by slink): * status: new => closed * resolution: => invalid Comment: set {{{vcc_err_unref}}} to off -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 8 11:12:53 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 08 Aug 2014 11:12:53 -0000 Subject: [Varnish] #1571: Wrong data type assignment Message-ID: <046.c44d2743a9f601241c95101dd892828b@varnish-cache.org> #1571: Wrong data type assignment ----------------------+---------------------- Reporter: zviratko | Type: defect Status: new | Priority: normal Milestone: | Component: varnishd Version: 4.0.1 | Severity: normal Keywords: | ----------------------+---------------------- This does not compile set req.http.X-Hash-Key = client.ip + " " + req.url; because X-Hash-Key becomes auto-typed as IP This works: set req.http.X-Hash-Key = req.url + " " + client.ip; I believe this should intelligently default to string either way? -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 11 10:17:20 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 11 Aug 2014 10:17:20 -0000 Subject: [Varnish] #1568: director.hash with req.http.Cookie && empty req.http.Cookie results in SIGSEGV In-Reply-To: <046.f62a984b7424f6d73a1a93d957d4563d@varnish-cache.org> References: <046.f62a984b7424f6d73a1a93d957d4563d@varnish-cache.org> Message-ID: <061.3d924d655793214a8420e108a30d6a2f@varnish-cache.org> #1568: director.hash with req.http.Cookie && empty req.http.Cookie results in SIGSEGV ------------------------------------+---------------------------------- Reporter: zviratko | Owner: slink Type: defect | Status: new Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: segfault hash director | ------------------------------------+---------------------------------- Changes (by slink): * owner: => slink -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 11 10:24:18 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 11 Aug 2014 10:24:18 -0000 Subject: =?utf-8?q?Re=3A_=5BVarnish=5D_=231567=3A_error=3A_unused_variabl?= =?utf-8?b?ZSDigJh0duKAmSBhdCBjYWNoZV9hY2NlcHRvci5jIGF0IGNvbXBp?= =?utf-8?q?lation_time_=28Solaris_and_Cygwin=29?= In-Reply-To: <043.22f815a5f6d390bb075af3de6a0aa869@varnish-cache.org> References: <043.22f815a5f6d390bb075af3de6a0aa869@varnish-cache.org> Message-ID: <058.fcfc2788e1cb6c76bfa119e1aa176d85@varnish-cache.org> #1567: error: unused variable ?tv? at cache_acceptor.c at compilation time (Solaris and Cygwin) --------------------+--------------------- Reporter: jdzst | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: build | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by fgsch): * status: new => closed * resolution: => fixed Comment: Fixed in rev c36069c5ca7a47d742353368a07705e2f2900c2e. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 11 10:30:18 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 11 Aug 2014 10:30:18 -0000 Subject: =?utf-8?q?Re=3A_=5BVarnish=5D_=231567=3A_error=3A_unused_variabl?= =?utf-8?b?ZSDigJh0duKAmSBhdCBjYWNoZV9hY2NlcHRvci5jIGF0IGNvbXBp?= =?utf-8?q?lation_time_=28Solaris_and_Cygwin=29?= In-Reply-To: <043.22f815a5f6d390bb075af3de6a0aa869@varnish-cache.org> References: <043.22f815a5f6d390bb075af3de6a0aa869@varnish-cache.org> Message-ID: <058.0dbeccadd5ebf8aaf9f6c18ee7d628af@varnish-cache.org> #1567: error: unused variable ?tv? at cache_acceptor.c at compilation time (Solaris and Cygwin) --------------------+----------------------- Reporter: jdzst | Owner: Type: defect | Status: reopened Priority: normal | Milestone: Component: build | Version: 4.0.1 Severity: normal | Resolution: Keywords: | --------------------+----------------------- Changes (by fgsch): * status: closed => reopened * resolution: fixed => -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 11 14:36:13 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 11 Aug 2014 14:36:13 -0000 Subject: [Varnish] #1507: varnishstat is missing cache hit ratio In-Reply-To: <041.dd00f17339d5a9cb13ffc84055c90494@varnish-cache.org> References: <041.dd00f17339d5a9cb13ffc84055c90494@varnish-cache.org> Message-ID: <056.6b5dadc5bd07fb892a714f15a0ec4686@varnish-cache.org> #1507: varnishstat is missing cache hit ratio -------------------------+-------------------- Reporter: Tin | Owner: fgsch Type: defect | Status: new Priority: normal | Milestone: Component: build | Version: 4.0.0 Severity: normal | Resolution: Keywords: varnishstat | -------------------------+-------------------- Comment (by aondio): Varnishstat hitrate implemented. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 11 14:51:27 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 11 Aug 2014 14:51:27 -0000 Subject: [Varnish] #1507: varnishstat is missing cache hit ratio In-Reply-To: <041.dd00f17339d5a9cb13ffc84055c90494@varnish-cache.org> References: <041.dd00f17339d5a9cb13ffc84055c90494@varnish-cache.org> Message-ID: <056.6cc65ff2fd04c92707122617e0a6119a@varnish-cache.org> #1507: varnishstat is missing cache hit ratio -------------------------+--------------------- Reporter: Tin | Owner: fgsch Type: defect | Status: closed Priority: normal | Milestone: Component: build | Version: 4.0.0 Severity: normal | Resolution: fixed Keywords: varnishstat | -------------------------+--------------------- Changes (by fgsch): * status: new => closed * resolution: => fixed Comment: Fixed in commit c6f20e4701cfc7484a8bc064e7c6f41de243865d. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 11 15:38:36 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 11 Aug 2014 15:38:36 -0000 Subject: =?utf-8?q?Re=3A_=5BVarnish=5D_=231567=3A_error=3A_unused_variabl?= =?utf-8?b?ZSDigJh0duKAmSBhdCBjYWNoZV9hY2NlcHRvci5jIGF0IGNvbXBp?= =?utf-8?q?lation_time_=28Solaris_and_Cygwin=29?= In-Reply-To: <043.22f815a5f6d390bb075af3de6a0aa869@varnish-cache.org> References: <043.22f815a5f6d390bb075af3de6a0aa869@varnish-cache.org> Message-ID: <058.354d6d1e98c18fd4f9890a30f9cf3afc@varnish-cache.org> #1567: error: unused variable ?tv? at cache_acceptor.c at compilation time (Solaris and Cygwin) --------------------+--------------------------------------------- Reporter: jdzst | Owner: Federico G. Schwindt Type: defect | Status: closed Priority: normal | Milestone: Component: build | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: | --------------------+--------------------------------------------- Changes (by Federico G. Schwindt ): * owner: => Federico G. Schwindt * status: reopened => closed * resolution: => fixed Comment: In [716810bb51a8517c304ec34543b3426ad247bcbb]: {{{ #!CommitTicketReference repository="" revision="716810bb51a8517c304ec34543b3426ad247bcbb" Fix compilation if SO_{SND,RCV}TIMEO_WORKS is not defined Fixes #1567 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 13 09:16:17 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 13 Aug 2014 09:16:17 -0000 Subject: [Varnish] #1572: varnishd -C should return correct exit value Message-ID: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> #1572: varnishd -C should return correct exit value ----------------------+---------------------- Reporter: zviratko | Type: defect Status: new | Priority: normal Milestone: | Component: varnishd Version: 4.0.1 | Severity: normal Keywords: | ----------------------+---------------------- varnishd -C should return correct exit value 1) vcc_err_unref = on and there are unreferenced object varnishd -C returns with 2 but prints: "Running VCC-compiler failed, exit 1" 2) vcc_err_unref=off and there are unreferenced objects varnishd -C returns with 0, should return with 1 -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 13 14:48:39 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 13 Aug 2014 14:48:39 -0000 Subject: [Varnish] #1454: XFF is not handled in C In-Reply-To: <046.2060dad0d9d3c50788cb49f268e7db35@varnish-cache.org> References: <046.2060dad0d9d3c50788cb49f268e7db35@varnish-cache.org> Message-ID: <061.70653b936033a2a69fc7decd9bcb2306@varnish-cache.org> #1454: XFF is not handled in C ----------------------+---------------------------------- Reporter: lkarsten | Owner: tfheen Type: defect | Status: closed Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: trunk Severity: normal | Resolution: fixed Keywords: | ----------------------+---------------------------------- Comment (by denis): Why was this done? We use haproxy before Varnish to terminate ssl and this makes Varnish always append our internal IP address to x-forwarded-for, which is not needed. Previously, I just deleted the related section from VCL, but it's not longer possible. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 14 14:30:50 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 14 Aug 2014 14:30:50 -0000 Subject: [Varnish] #1573: Can't Open VSM file Message-ID: <046.91838a65bb73f165874d1ecbf27ef1bb@varnish-cache.org> #1573: Can't Open VSM file ---------------------------------+-------------------- Reporter: pmcnealy | Type: defect Status: new | Priority: normal Milestone: Varnish 4.0 release | Component: build Version: unknown | Severity: normal Keywords: | ---------------------------------+-------------------- We are trying to configure Varnish and are having trouble getting it to function. Below are the errors we are encountering; would you be able to help us diagnose this? root at sup.superbiketoystore.com [~]# service varnish restart Stopping Varnish Cache: [FAILED] Starting Varnish Cache: 0 [FAILED] root at sup.superbiketoystore.com [~]# varnishstat Abandoned VSM file (Varnish not running?) /var/lib/varnish/sup.superbiketoystore.com/_.vsm root at sup.superbiketoystore.com [~]# varnishlog Can't open VSM file (Abandoned VSM file (Varnish not running?) /var/lib/varnish/sup.superbiketoystore.com/_.vsm ) Any help you could provide will be greatly appreciated. Thanks! Patrick -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 15 06:52:05 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 15 Aug 2014 06:52:05 -0000 Subject: [Varnish] #1544: segfault at 40 error 4 in varnishd In-Reply-To: <049.7736650ccfff554fe37de96b015b88fc@varnish-cache.org> References: <049.7736650ccfff554fe37de96b015b88fc@varnish-cache.org> Message-ID: <064.c84127b17aa23298585694b163fe9e9e@varnish-cache.org> #1544: segfault at 40 error 4 in varnishd -------------------------+----------------------- Reporter: g.gerritsen | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | -------------------------+----------------------- Comment (by spexxter): We have the same problem - our production cache keeps dieing with this error in syslog Aug 14 23:36:28 dba-vsh-f01-03 kernel: [13251687.578531] varnishd[3152]: segfault at 40 ip 0000000000418bf0 sp 00007e9dedf86170 error 4 in varnishd[400000+88000] Aug 14 23:36:32 dba-vsh-f01-03 varnishd[39180]: Child (39222) not responding to CLI, killing it. Aug 14 23:36:32 dba-vsh-f01-03 varnishd[39180]: Child (39222) not responding to CLI, killing it. Aug 14 23:36:33 dba-vsh-f01-03 varnishd[39180]: Child (39222) died signal=11 Aug 14 23:36:33 dba-vsh-f01-03 varnishd[39180]: Child cleanup complete Aug 14 23:36:33 dba-vsh-f01-03 varnishd[39180]: child (43191) Started Aug 14 23:36:33 dba-vsh-f01-03 varnishd[39180]: Child (43191) said Child starts Aug 14 23:36:33 dba-vsh-f01-03 varnishd[39180]: Child (43191) said SMF.s0 mmap'ed 644245094400 bytes of 644245094400 Aug 14 23:36:55 dba-vsh-f01-03 snmpd[1434]: Connection from UDP: [10.70.66.16]:56303->[10.70.79.10] We need a fix for this ASAP! [System information] OS Linux dba-vsh-f01-03 3.2.0-4-amd64 #1 SMP Debian 3.2.60-1+deb7u3 x86_64 GNU/Linux CPU model name : Intel(R) Xeon(R) CPU E5-2620 0 @ 2.00GHz RAM MemTotal: 99162232 kB MemFree: 95917980 kB Buffers: 14260 kB Cached: 2350804 kB SwapCached: 0 kB VARNISH ii varnish 4.0.1-2~wheezy amd64 state of MUNIN ii munin-common 2.0.6-4+deb7u2 all network-wide graphing framework (common) ii munin-node 2.0.6-4+deb7u2 all network-wide graphing framework (node) ii munin-plugins-core 2.0.6-4+deb7u2 all network-wide graphing framework (plugins for node) ii munin-plugins-extra 2.0.6-4+deb7u2 all network-w -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 15 17:15:17 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 15 Aug 2014 17:15:17 -0000 Subject: [Varnish] #1573: Can't Open VSM file In-Reply-To: <046.91838a65bb73f165874d1ecbf27ef1bb@varnish-cache.org> References: <046.91838a65bb73f165874d1ecbf27ef1bb@varnish-cache.org> Message-ID: <061.a1fa54704d5cd9eafb7fd3a4f885d167@varnish-cache.org> #1573: Can't Open VSM file ----------------------+---------------------------------- Reporter: pmcnealy | Owner: Type: defect | Status: closed Priority: normal | Milestone: Varnish 4.0 release Component: build | Version: unknown Severity: normal | Resolution: invalid Keywords: | ----------------------+---------------------------------- Changes (by slink): * status: new => closed * resolution: => invalid Comment: This is not a place for support questions. Please consider using irc or the -misc mailing list. https://www.varnish-cache.org/lists/mailman/listinfo/varnish-misc/ -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 15 17:21:20 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 15 Aug 2014 17:21:20 -0000 Subject: [Varnish] #1544: segfault at 40 error 4 in varnishd In-Reply-To: <049.7736650ccfff554fe37de96b015b88fc@varnish-cache.org> References: <049.7736650ccfff554fe37de96b015b88fc@varnish-cache.org> Message-ID: <064.e2f5f033b5b56d6e864f1f56bea685da@varnish-cache.org> #1544: segfault at 40 error 4 in varnishd -------------------------+------------------------ Reporter: g.gerritsen | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: duplicate Keywords: | -------------------------+------------------------ Changes (by slink): * status: needinfo => closed * resolution: => duplicate Comment: This also very much smells like #1559, but as the users having reportet to this ticket run varnish without debugging symbols (and thus panics without stack traces), it is very hard to tell. Please test master if you cannot wait for 4.0.2 I will close this as duplicate, please re-open if you believe this is wrong. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 15 17:23:38 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 15 Aug 2014 17:23:38 -0000 Subject: [Varnish] #1454: XFF is not handled in C In-Reply-To: <046.2060dad0d9d3c50788cb49f268e7db35@varnish-cache.org> References: <046.2060dad0d9d3c50788cb49f268e7db35@varnish-cache.org> Message-ID: <061.dcb5e238904abb2578eae75b5c4c3989@varnish-cache.org> #1454: XFF is not handled in C ----------------------+---------------------------------- Reporter: lkarsten | Owner: tfheen Type: defect | Status: closed Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: trunk Severity: normal | Resolution: fixed Keywords: | ----------------------+---------------------------------- Comment (by slink): You can still Modify XFF in VCL. C-Code only sets a default which you are free to delete or change. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 18 10:02:21 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 18 Aug 2014 10:02:21 -0000 Subject: [Varnish] #1572: varnishd -C should return correct exit value In-Reply-To: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> References: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> Message-ID: <061.59a0374d3af34fda92efd19482cc137f@varnish-cache.org> #1572: varnishd -C should return correct exit value ----------------------+----------------------- Reporter: zviratko | Owner: slink Type: defect | Status: assigned Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Changes (by slink): * owner: => slink * status: new => assigned -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 18 10:19:31 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 18 Aug 2014 10:19:31 -0000 Subject: [Varnish] #1572: better exit codes - varnishd -C should return correct exit value (was: varnishd -C should return correct exit value) In-Reply-To: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> References: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> Message-ID: <061.56587317a31a9aa03135b99325f1d0fb@varnish-cache.org> #1572: better exit codes - varnishd -C should return correct exit value ----------------------+----------------------- Reporter: zviratko | Owner: slink Type: defect | Status: assigned Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 18 10:20:11 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 18 Aug 2014 10:20:11 -0000 Subject: [Varnish] #1572: better exit codes - varnishd -C should return correct exit value In-Reply-To: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> References: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> Message-ID: <061.ee38592f8e476ace23a2d654eb9e5819@varnish-cache.org> #1572: better exit codes - varnishd -C should return correct exit value ----------------------+----------------------- Reporter: zviratko | Owner: slink Type: defect | Status: assigned Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by slink): We'll also revisit some more exit codes and try to make them more consistent. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 18 10:32:43 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 18 Aug 2014 10:32:43 -0000 Subject: [Varnish] #1568: director.hash with req.http.Cookie && empty req.http.Cookie results in SIGSEGV In-Reply-To: <046.f62a984b7424f6d73a1a93d957d4563d@varnish-cache.org> References: <046.f62a984b7424f6d73a1a93d957d4563d@varnish-cache.org> Message-ID: <061.9dae9baff81f66263057592dd6064d5a@varnish-cache.org> #1568: director.hash with req.http.Cookie && empty req.http.Cookie results in SIGSEGV ------------------------------------+---------------------------------- Reporter: zviratko | Owner: slink Type: defect | Status: closed Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: segfault hash director | ------------------------------------+---------------------------------- Changes (by Nils Goroll ): * status: new => closed * resolution: => fixed Comment: In [b0d96f6a6049904f702dcae3238d3e00af23ae62]: {{{ #!CommitTicketReference repository="" revision="b0d96f6a6049904f702dcae3238d3e00af23ae62" Skip NULL and empty arguments when hashing. Hash all other arguments. When multiple arguments were passed to vmod_hash_backend, only the first argument was re-used for the number of arguments passed. Fixes #1568 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 18 19:27:49 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 18 Aug 2014 19:27:49 -0000 Subject: [Varnish] #1555: configure not checking for readline.h, giving make error after fixing it. In-Reply-To: <041.90d39daf5df6b4940eecfab0845b4b93@varnish-cache.org> References: <041.90d39daf5df6b4940eecfab0845b4b93@varnish-cache.org> Message-ID: <056.0c622b5bae5fe838403e8cd69cf99962@varnish-cache.org> #1555: configure not checking for readline.h, giving make error after fixing it. -------------------------------------------------+------------------------- Reporter: Tin | Owner: slink Type: defect | Status: closed Priority: normal | Milestone: Component: build | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: readline.h not checked by configure | script | -------------------------------------------------+------------------------- Changes (by Nils Goroll ): * status: new => closed * resolution: => fixed Comment: In [7c0e75f0abc29ead11f945318274cf4e5669eedb]: {{{ #!CommitTicketReference repository="" revision="7c0e75f0abc29ead11f945318274cf4e5669eedb" Rework autocrap configuration for libedit/libreadline As before, libedit is preferred over libreadline. Fail configure if neither is found or if libedit includes are missing. Require readline history support (as varnishadm needs it). Previously, if only libreadline was found, all binaries were linked against it. Now only binaries getting linked with LIBEDIT_LIBS will get linked aginst readline if libedit is not found. If configure succeeds, a build should not fail any longer due to libedit/libreadline headers missing. Fixes #1555 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 19 09:34:36 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 19 Aug 2014 09:34:36 -0000 Subject: [Varnish] #1574: std.syslog creates empty syslog entry Message-ID: <046.b58d20ea1b6449358a9ac17c6df3c9c6@varnish-cache.org> #1574: std.syslog creates empty syslog entry ----------------------+-------------------- Reporter: kipusoep | Type: defect Status: new | Priority: normal Milestone: | Component: vmod Version: 4.0.1 | Severity: normal Keywords: syslog | ----------------------+-------------------- I've experienced this on a clean installation of Debian (7.6.0, amd64) with the latest Varnish v4.0.1 release. Calling std.syslog creates an empty entry in the syslog, for example by using: std.syslog(180, "Test"); -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 19 09:50:13 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 19 Aug 2014 09:50:13 -0000 Subject: [Varnish] #1574: std.syslog creates empty syslog entry In-Reply-To: <046.b58d20ea1b6449358a9ac17c6df3c9c6@varnish-cache.org> References: <046.b58d20ea1b6449358a9ac17c6df3c9c6@varnish-cache.org> Message-ID: <061.0114ec3884032cf23be22eba4d88f283@varnish-cache.org> #1574: std.syslog creates empty syslog entry ----------------------+--------------------------------------------- Reporter: kipusoep | Owner: Federico G. Schwindt Type: defect | Status: closed Priority: normal | Milestone: Component: vmod | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: syslog | ----------------------+--------------------------------------------- Changes (by Federico G. Schwindt ): * owner: => Federico G. Schwindt * status: new => closed * resolution: => fixed Comment: In [1dc22f0c75f5546272ac0b06f2a44c4b643d07dd]: {{{ #!CommitTicketReference repository="" revision="1dc22f0c75f5546272ac0b06f2a44c4b643d07dd" Pass the right string to syslog() Fixes #1574 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 19 13:50:23 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 19 Aug 2014 13:50:23 -0000 Subject: [Varnish] #1575: Health in random-director does not work Message-ID: <042.ba6e81edab67dee0d2d688995d3c45f5@varnish-cache.org> #1575: Health in random-director does not work -------------------+-------------------- Reporter: olli | Type: defect Status: new | Priority: normal Milestone: | Component: build Version: 4.0.1 | Severity: normal Keywords: | -------------------+-------------------- Hi, I wanted to use the random director in varnish 4.0.1 with 10 backend- server. The healthchecks are working very well if I bring down some backends. They are marked as "sick". But varnishd still tries to send the requests to the "sick" backends and produces a 503. If i use the round- robin director everything works fine. The random-director seems to be broken -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 21 13:54:42 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 21 Aug 2014 13:54:42 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 Message-ID: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 -------------------+---------------------- Reporter: abdi | Type: defect Status: new | Priority: normal Milestone: | Component: varnishd Version: 4.0.1 | Severity: normal Keywords: | -------------------+---------------------- I am running varnish 4.0.0 and now 4.0.1 on 64 bit debian 7 both have the same problem. Varnish child process crashes with the following error in syslog: ------- Aug 20 11:31:52 BMCWS01LIV kernel: [ 4042.695639] varnishd[28375]: segfault at 7f06e01c3f20 ip 00007f06ebdf87ed sp 00007f06e01c3ee0 error 6 in libpcre.so.3.13.1[7f06ebde5000+3c000] Aug 20 11:31:53 BMCWS01LIV varnishd[28311]: Child (28320) died signal=11 Aug 20 11:31:54 BMCWS01LIV varnishd[28311]: Child cleanup complete Aug 20 11:31:54 BMCWS01LIV varnishd[28311]: child (30494) Started Aug 20 11:31:55 BMCWS01LIV varnishd[28311]: Child (30494) said Child starts Aug 20 11:31:55 BMCWS01LIV varnishd[28311]: Child (30494) said SMF.s0 mmap'ed 2147483648 bytes of 2147483648 ------- snippet from the coredump: ------- #67 0x00007feef1fdc77c in pcre_exec () from /lib/x86_64-linux- gnu/libpcre.so.3 #68 0x00007feef2a83838 in VRE_exec () from /usr/sbin/lib/varnish/libvarnish.so #69 0x0000000000450482 in VRT_re_match () #70 0x00007feee74ece13 in ?? () ------- Thanks, Abdi -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 22 12:25:43 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 22 Aug 2014 12:25:43 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 In-Reply-To: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> References: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> Message-ID: <057.6d30550bc1d1e32de91f965e68611931@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 ----------------------+----------------------- Reporter: abdi | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Changes (by fgsch): * status: new => needinfo Comment: Have you compiled Varnish youself? Please also provide your VCL. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 22 13:04:22 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 22 Aug 2014 13:04:22 -0000 Subject: [Varnish] #1575: Health in random-director does not work In-Reply-To: <042.ba6e81edab67dee0d2d688995d3c45f5@varnish-cache.org> References: <042.ba6e81edab67dee0d2d688995d3c45f5@varnish-cache.org> Message-ID: <057.627d3e33a25b576ce906c06d08bea9ec@varnish-cache.org> #1575: Health in random-director does not work --------------------+-------------------- Reporter: olli | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: build | Version: 4.0.1 Severity: normal | Resolution: Keywords: | --------------------+-------------------- Comment (by fgsch): Confirmed. The problem is the nloops value in vmod_random__init(). The hash director suffers from the same problem. phk: any reason not to drop nloops and use rr->vd->n_backend directly? -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 22 13:04:46 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 22 Aug 2014 13:04:46 -0000 Subject: [Varnish] #1577: Varnish doesn't discard the request body on return synth from vcl_recv Message-ID: <044.02edb34b61d5c2b60cc105ae9183d745@varnish-cache.org> #1577: Varnish doesn't discard the request body on return synth from vcl_recv ----------------------+------------------- Reporter: martin | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: normal | Keywords: ----------------------+------------------- SSIA See attached test case and proposed patch Martin -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 22 15:13:56 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 22 Aug 2014 15:13:56 -0000 Subject: [Varnish] #1578: Problem in the TTL calculation, if have age and max-age Message-ID: <042.93a8b52b6311da14732c1825ae36a8cc@varnish-cache.org> #1578: Problem in the TTL calculation, if have age and max-age -------------------+---------------------- Reporter: xcir | Type: defect Status: new | Priority: normal Milestone: | Component: varnishd Version: 4.0.1 | Severity: normal Keywords: | -------------------+---------------------- Hi, I found a event that TTL is shorter, if have max-age and age. https://github.com/varnish/Varnish- Cache/blob/16e07984abbeac8fa5a014175efd164e8e90d1a8/bin/varnishd/cache/cache_rfc2616.c#L103 Age affect the t_origin. But, age affect again, if have max-age. https://github.com/varnish/Varnish- Cache/blob/16e07984abbeac8fa5a014175efd164e8e90d1a8/bin/varnishd/cache/cache_rfc2616.c#L142 Age will double effect. ---sample(php) {{{ }}} ---vcl {{{ sub vcl_backend_response { set beresp.http.x-ttl = beresp.ttl; set beresp.grace = 0s; } sub vcl_hit{ std.log("obj.ttl:"+obj.ttl); } }}} ---Before {{{ root at varnish4a:~/git/Varnish-Cache# /tmp/varnish4/bin/varnishncsa -F"%t %{Varnish:hitmiss}x [Age]:%{age}o [obj.ttl]:%{VCL_Log:obj.ttl}x [beresp.ttl]:%{x-ttl}o" [22/Aug/2014:23:27:23 +0900] miss [Age]:2 [obj.ttl]: [beresp.ttl]:8.000 //Remaining TTL 6 seconds. [22/Aug/2014:23:27:24 +0900] hit [Age]:3 [obj.ttl]:5.289 [beresp.ttl]:8.000 [22/Aug/2014:23:27:29 +0900] hit [Age]:7 [obj.ttl]:0.522 [beresp.ttl]:8.000 [22/Aug/2014:23:27:29 +0900] hit [Age]:8 [obj.ttl]:0.235 [beresp.ttl]:8.000 [22/Aug/2014:23:27:29 +0900] miss [Age]:2 [obj.ttl]: [beresp.ttl]:8.000 [22/Aug/2014:23:27:30 +0900] hit [Age]:2 [obj.ttl]:5.690 [beresp.ttl]:8.000 [22/Aug/2014:23:27:30 +0900] hit [Age]:3 [obj.ttl]:5.315 [beresp.ttl]:8.000 [22/Aug/2014:23:27:34 +0900] hit [Age]:7 [obj.ttl]:1.259 [beresp.ttl]:8.000 [22/Aug/2014:23:27:34 +0900] hit [Age]:7 [obj.ttl]:0.899 [beresp.ttl]:8.000 [22/Aug/2014:23:27:35 +0900] hit [Age]:7 [obj.ttl]:0.522 [beresp.ttl]:8.000 [22/Aug/2014:23:27:35 +0900] hit [Age]:8 [obj.ttl]:0.147 [beresp.ttl]:8.000 [22/Aug/2014:23:27:35 +0900] miss [Age]:2 [obj.ttl]: [beresp.ttl]:8.000 [22/Aug/2014:23:27:36 +0900] hit [Age]:2 [obj.ttl]:5.642 [beresp.ttl]:8.000 [22/Aug/2014:23:27:36 +0900] hit [Age]:3 [obj.ttl]:5.274 [beresp.ttl]:8.000 [22/Aug/2014:23:27:36 +0900] hit [Age]:3 [obj.ttl]:4.961 [beresp.ttl]:8.000 [22/Aug/2014:23:27:37 +0900] hit [Age]:3 [obj.ttl]:4.625 [beresp.ttl]:8.000 }}} --After(apply patch) {{{ [22/Aug/2014:23:32:41 +0900] miss [Age]:2 [obj.ttl]: [beresp.ttl]:10.000 //Remaining TTL 8 seconds. [22/Aug/2014:23:32:42 +0900] hit [Age]:3 [obj.ttl]:7.355 [beresp.ttl]:10.000 [22/Aug/2014:23:32:42 +0900] hit [Age]:3 [obj.ttl]:6.690 [beresp.ttl]:10.000 [22/Aug/2014:23:32:43 +0900] hit [Age]:4 [obj.ttl]:6.224 [beresp.ttl]:10.000 [22/Aug/2014:23:32:43 +0900] hit [Age]:4 [obj.ttl]:5.754 [beresp.ttl]:10.000 [22/Aug/2014:23:32:47 +0900] hit [Age]:8 [obj.ttl]:2.020 [beresp.ttl]:10.000 [22/Aug/2014:23:32:47 +0900] hit [Age]:8 [obj.ttl]:1.610 [beresp.ttl]:10.000 [22/Aug/2014:23:32:48 +0900] hit [Age]:9 [obj.ttl]:1.171 [beresp.ttl]:10.000 [22/Aug/2014:23:32:48 +0900] hit [Age]:9 [obj.ttl]:0.794 [beresp.ttl]:10.000 [22/Aug/2014:23:32:49 +0900] hit [Age]:10 [obj.ttl]:0.362 [beresp.ttl]:10.000 [22/Aug/2014:23:32:49 +0900] miss [Age]:2 [obj.ttl]: [beresp.ttl]:10.000 [22/Aug/2014:23:32:49 +0900] hit [Age]:2 [obj.ttl]:7.641 [beresp.ttl]:10.000 [22/Aug/2014:23:32:50 +0900] hit [Age]:3 [obj.ttl]:7.234 [beresp.ttl]:10.000 [22/Aug/2014:23:32:50 +0900] hit [Age]:3 [obj.ttl]:6.881 [beresp.ttl]:10.000 [22/Aug/2014:23:32:51 +0900] hit [Age]:4 [obj.ttl]:6.474 [beresp.ttl]:10.000 [22/Aug/2014:23:32:51 +0900] hit [Age]:4 [obj.ttl]:6.074 [beresp.ttl]:10.000 [22/Aug/2014:23:32:55 +0900] hit [Age]:8 [obj.ttl]:2.105 [beresp.ttl]:10.000 [22/Aug/2014:23:32:55 +0900] hit [Age]:8 [obj.ttl]:1.705 [beresp.ttl]:10.000 [22/Aug/2014:23:32:56 +0900] hit [Age]:9 [obj.ttl]:1.337 [beresp.ttl]:10.000 [22/Aug/2014:23:32:56 +0900] hit [Age]:9 [obj.ttl]:0.888 [beresp.ttl]:10.000 [22/Aug/2014:23:32:57 +0900] hit [Age]:9 [obj.ttl]:0.534 [beresp.ttl]:10.000 [22/Aug/2014:23:32:57 +0900] hit [Age]:10 [obj.ttl]:0.138 [beresp.ttl]:10.000 [22/Aug/2014:23:32:57 +0900] miss [Age]:2 [obj.ttl]: [beresp.ttl]:10.000 [22/Aug/2014:23:32:58 +0900] hit [Age]:2 [obj.ttl]:7.587 [beresp.ttl]:10.000 [22/Aug/2014:23:32:58 +0900] hit [Age]:3 [obj.ttl]:7.194 [beresp.ttl]:10.000 [22/Aug/2014:23:32:59 +0900] hit [Age]:3 [obj.ttl]:6.763 [beresp.ttl]:10.000 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 22 20:03:46 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 22 Aug 2014 20:03:46 -0000 Subject: [Varnish] #1454: XFF is not handled in C In-Reply-To: <046.2060dad0d9d3c50788cb49f268e7db35@varnish-cache.org> References: <046.2060dad0d9d3c50788cb49f268e7db35@varnish-cache.org> Message-ID: <061.0768be94e631566f559f27fa1ef510a9@varnish-cache.org> #1454: XFF is not handled in C ----------------------+---------------------------------- Reporter: lkarsten | Owner: tfheen Type: defect | Status: closed Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: trunk Severity: normal | Resolution: fixed Keywords: | ----------------------+---------------------------------- Comment (by eknkc): Replying to [comment:3 slink]: > You can still Modify XFF in VCL. C-Code only sets a default which you are free to delete or change. But this change basically hides the original XFF header from VCL. I have a similar situation where our varnish servers are behind Amazon's load balancer. We don't need or want the ELB's IP in XFF header. Anyway I added this to the vcl_recv to undo what Varnish does beforehand: {{{ if (req.restarts == 0 && req.http.x-forwarded-for) { set req.http.X-Forwarded-For = regsub(req.http.x-forwarded-for, "^(.*),([^,]+)$", "\1"); } }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 25 11:01:26 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 25 Aug 2014 11:01:26 -0000 Subject: [Varnish] #1577: Varnish doesn't discard the request body on return synth from vcl_recv In-Reply-To: <044.02edb34b61d5c2b60cc105ae9183d745@varnish-cache.org> References: <044.02edb34b61d5c2b60cc105ae9183d745@varnish-cache.org> Message-ID: <059.f862a0fd2a96861f1575850fac556471@varnish-cache.org> #1577: Varnish doesn't discard the request body on return synth from vcl_recv ----------------------+----------------------------------------------- Reporter: martin | Owner: Martin Blix Grydeland Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: normal | Resolution: fixed Keywords: | ----------------------+----------------------------------------------- Changes (by Martin Blix Grydeland ): * owner: => Martin Blix Grydeland * status: new => closed * resolution: => fixed Comment: In [0a6e8a6cac45ee56a3f69f0e8f3ad4df23d33250]: {{{ #!CommitTicketReference repository="" revision="0a6e8a6cac45ee56a3f69f0e8f3ad4df23d33250" Deal with any remaining request body in cnt_synth Call HTTP1_DiscardReqBody() in cnt_synth before delivery to deal with any lingering request body. Fixes: #1577 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 25 11:02:35 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 25 Aug 2014 11:02:35 -0000 Subject: [Varnish] #1577: Varnish doesn't discard the request body on return synth from vcl_recv In-Reply-To: <044.02edb34b61d5c2b60cc105ae9183d745@varnish-cache.org> References: <044.02edb34b61d5c2b60cc105ae9183d745@varnish-cache.org> Message-ID: <059.4689fe49f2991e0b6e2c0d7d71298c09@varnish-cache.org> #1577: Varnish doesn't discard the request body on return synth from vcl_recv ----------------------+----------------------------------------------- Reporter: martin | Owner: Martin Blix Grydeland Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: normal | Resolution: fixed Keywords: | ----------------------+----------------------------------------------- Comment (by Martin Blix Grydeland ): In [d11d4419f3f9fa1d70e984f80c2078ea44e9e53c]: {{{ #!CommitTicketReference repository="" revision="d11d4419f3f9fa1d70e984f80c2078ea44e9e53c" Deal with any remaining request body in cnt_synth Call HTTP1_DiscardReqBody() in cnt_synth before delivery to deal with any lingering request body. Fixes: #1577 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 25 11:03:12 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 25 Aug 2014 11:03:12 -0000 Subject: [Varnish] #1578: Problem in the TTL calculation, if have age and max-age In-Reply-To: <042.93a8b52b6311da14732c1825ae36a8cc@varnish-cache.org> References: <042.93a8b52b6311da14732c1825ae36a8cc@varnish-cache.org> Message-ID: <057.b6a71e948aaa3ce2dab695a89e548078@varnish-cache.org> #1578: Problem in the TTL calculation, if have age and max-age ----------------------+------------------------------------------ Reporter: xcir | Owner: Nils Goroll Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: | ----------------------+------------------------------------------ Changes (by Nils Goroll ): * status: new => closed * owner: => Nils Goroll * resolution: => fixed Comment: In [4e9fb4b339b7df0679609d699aa7f5c31aa32595]: {{{ #!CommitTicketReference repository="" revision="4e9fb4b339b7df0679609d699aa7f5c31aa32595" Set default ttl (according to rfc2616 rules) to max-age, do not use Age twice With 160927b690dd076702601b7407eb71bd423c62dd t_origin got corrected by Age, so we already took the age the object had at fetch time into consideration for all other calculations. Fixes #1578 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 25 11:28:03 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 25 Aug 2014 11:28:03 -0000 Subject: [Varnish] #1575: Health in random-director does not work In-Reply-To: <042.ba6e81edab67dee0d2d688995d3c45f5@varnish-cache.org> References: <042.ba6e81edab67dee0d2d688995d3c45f5@varnish-cache.org> Message-ID: <057.afd9ad9d7e768a491fb8954d1f16290f@varnish-cache.org> #1575: Health in random-director does not work --------------------+-------------------- Reporter: olli | Owner: phk Type: defect | Status: new Priority: normal | Milestone: Component: build | Version: 4.0.1 Severity: normal | Resolution: Keywords: | --------------------+-------------------- Changes (by slink): * owner: => phk -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 25 11:28:19 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 25 Aug 2014 11:28:19 -0000 Subject: [Varnish] #1571: Wrong data type assignment In-Reply-To: <046.c44d2743a9f601241c95101dd892828b@varnish-cache.org> References: <046.c44d2743a9f601241c95101dd892828b@varnish-cache.org> Message-ID: <061.be4ee00f161fe50c508130ca91e90717@varnish-cache.org> #1571: Wrong data type assignment ----------------------+-------------------- Reporter: zviratko | Owner: phk Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+-------------------- Changes (by slink): * owner: => phk -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 25 11:28:37 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 25 Aug 2014 11:28:37 -0000 Subject: [Varnish] #1569: having a subroutine named the same as backend results in Symbol not found In-Reply-To: <046.b47c55eccca631613556802863c1030c@varnish-cache.org> References: <046.b47c55eccca631613556802863c1030c@varnish-cache.org> Message-ID: <061.d875160122e8bd9dcbbc5ae22d915851@varnish-cache.org> #1569: having a subroutine named the same as backend results in Symbol not found ----------------------+---------------------------------- Reporter: zviratko | Owner: phk Type: defect | Status: new Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+---------------------------------- Changes (by slink): * owner: => phk -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 25 11:38:46 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 25 Aug 2014 11:38:46 -0000 Subject: [Varnish] #1525: free() in VBO_DerefBusyObj causes child crash In-Reply-To: <044.d5889a74d0ac7c4cb6b2eb7d0991d0bb@varnish-cache.org> References: <044.d5889a74d0ac7c4cb6b2eb7d0991d0bb@varnish-cache.org> Message-ID: <059.5e2c19d53cc3079411bc9876039bc9aa@varnish-cache.org> #1525: free() in VBO_DerefBusyObj causes child crash ----------------------+-------------------- Reporter: joakim | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: Keywords: | ----------------------+-------------------- Comment (by slink): joakim, your bugs #1525 #1527 #1528 #1529 could well have a reason outside varnish code. The fact that you have been the only reporter of such fundamental issues seem to support this hypothesis. Do you have any additional insight on these or do you have made progress on either avoiding to run into these issues or being able to reproduce them? -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Mon Aug 25 11:38:54 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Mon, 25 Aug 2014 11:38:54 -0000 Subject: [Varnish] #1525: free() in VBO_DerefBusyObj causes child crash In-Reply-To: <044.d5889a74d0ac7c4cb6b2eb7d0991d0bb@varnish-cache.org> References: <044.d5889a74d0ac7c4cb6b2eb7d0991d0bb@varnish-cache.org> Message-ID: <059.cbf4400431b169815a1d51206f0667ec@varnish-cache.org> #1525: free() in VBO_DerefBusyObj causes child crash ----------------------+----------------------- Reporter: joakim | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Changes (by slink): * status: new => needinfo -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 09:25:13 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 09:25:13 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 In-Reply-To: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> References: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> Message-ID: <057.c8be584678da09a44027be5c2bfc299d@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 ----------------------+----------------------- Reporter: abdi | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by abdi): "Have you compiled Varnish youself?" no, I got it from varnish repository https://repo.varnish- cache.org/debian/pool/varnish-4.0/v/varnish/varnish_4.0.1-1~wheezy_amd64.deb Main VCL: ###### vcl 4.0; # Varnish Modules import std; import directors; # Backends definition include "/etc/varnish/backends.vcl"; # Access control list include "/etc/varnish/acl.vcl"; # Device detections include "/etc/varnish/devicedetect.vcl"; # Called when VCL is loaded, before any requests pass through it. Typically used # to initialize Varnish Modules. sub vcl_init { # Backend selection logic (directors configuration) for blogs. new blogs = directors.round_robin(); blogs.add_backend(blogs01); blogs.add_backend(blogs02); # Backend selection logic (directors configuration) for orders. new orders = directors.round_robin(); orders.add_backend(orders01); orders.add_backend(orders02); } sub vcl_recv { #Block bad guys include "/etc/varnish/block.vcl"; #Redirect before anything else include "/etc/varnish/redirects.vcl"; #Grace mode - Allow the backend to serve up stale content #set req.grace = 24h; #Clear the headers that we are going to set later unset req.http.X-Server-IP; unset req.http.X-Bmc-Remote-Addr; #Detect device and set X-UA-Device header call devicedetect; #Validate and pass client IP to Apache logs unset req.http.X-Forwarded-For; set req.http.X-Forwarded-For = client.ip; #Pass server IP to Apache logs set req.http.X-Server-IP = server.ip; #Pass client IP for Journal application set req.http.X-Bmc-Remote-Addr = req.http.X-Forwarded-For; # Set another header for blogs/Akamai set req.http.True-Client-IP = req.http.X-Forwarded-For; #Pass POST requests to log them properly if (req.method == "POST") { return (pass); } #We are handling only supported methods if (req.method != "GET" && req.method != "HEAD" && req.method != "PUT" && req.method != "TRACE" && req.method != "OPTIONS" && req.method != "DELETE") { /* Non-RFC2616 or CONNECT which is weird. */ return (pipe); } #Compression fix if (req.http.Accept-Encoding) { if (req.url ~ "\.(jpg|png|gif|gz|tgz|bz2|tbz|mp3|ogg|jpeg)$") { #No point in compressing these unset req.http.Accept-Encoding; } elsif(req.http.Accept-Encoding ~ "gzip") { set req.http.Accept-Encoding = "gzip"; } elsif(req.http.Accept-Encoding ~ "deflate" && req.http.User-Agent !~ "MSIE") { set req.http.Accept-Encoding = "deflate"; } else { #unkown algorithm unset req.http.Accept-Encoding; } } return (hash); } sub vcl_pipe { return (pipe); } sub vcl_pass { return (fetch); } sub vcl_hash { hash_data(req.url); if (req.http.host) { hash_data(req.http.host); } else { hash_data(server.ip); } hash_data(req.http.X-UA-Device); return (lookup); } sub vcl_hit { return (deliver); } sub vcl_miss { return (fetch); } sub vcl_backend_response { #Grace mode - Allow items to be stale if needed set beresp.grace = 24 h; #Default setting for cache set beresp.http.X-Cacheable = "NO"; #Varnish determined the object was cacheable if (include "/etc/varnish/cached_pages.vcl";) { set beresp.http.X-Cacheable = "YES"; } if (beresp.http.Set-Cookie ~ "bmccookie" || beresp.http.Cookie ~ "bmccookie" || bereq.http.Cookie ~ "bmccookie" || beresp.http.Set-Cookie ~ "wordpress" || beresp.http.Cookie ~ "wordpress" || bereq.http.cookie ~ "wordpress" || beresp.http.Set-Cookie ~ "wp-" || beresp.http.Cookie ~ "wp-" || bereq.http.Cookie ~ "wp-") { set beresp.http.X-Cacheable = "NO"; } if (beresp.http.Set-Cookie ~ "athens" || beresp.http.Cookie ~ "athens" || bereq.http.Cookie ~ "athens" || bereq.http.User-Agent ~ "pingdom_nocache") { set beresp.http.X-Cacheable = "NO"; } # Respect backend cache settings if (beresp.http.Cache-Control ~ "private" || beresp.http.Cache-Control ~ "no-cache" || beresp.http.Cache-Control ~ "no-store" || beresp.http.Cache-Control ~ "must-revalidate" || beresp.http.Pragma ~ "no-cache") { set beresp.http.X-Cacheable = "NO"; } if (beresp.http.X-Cacheable == "YES") { unset beresp.http.Cookie; unset beresp.http.Set-Cookie; unset bereq.http.Cookie; unset beresp.http.Etag; #Cache non 200s for 1s, set 1 hour TTL for XML (RSS) and 24H for others if (beresp.status != 200) { set beresp.ttl = 1 s; } elsif (beresp.http.Content-Type ~ "application/json;charset=[Uu][Tt][Ff]-8" || beresp.http.Content-Type ~ "application/xml;charset=[Uu][Tt][Ff]-8" || beresp.http.Content-Type ~ "text/html;charset=[Uu][Tt][Ff]-8") { set beresp.ttl = 1 h; } else { set beresp.ttl = 24 h; } #Remove Expires from backend, it's not long enough unset beresp.http.expires; #Set the clients TTL on this object if it doesn't exist if (!(beresp.http.Cache-control)) { if (bereq.url == "/") { set beresp.http.Cache-Control = "max-age=0"; } else { set beresp.http.Cache-Control = "public,max-age=86400"; } } if (!beresp.http.Last-Modified) { set beresp.http.Last-Modified = beresp.http.date; } } #Send detected device back to browser if (!beresp.http.X-UA-Device) { set beresp.http.X-UA-Device = bereq.http.X-UA-Device; } #Modify server string and Vary header unset beresp.http.Server; set beresp.http.Server = "BioMed Central Web Server 1.0"; if (beresp.http.Vary ~ "User-Agent") { set beresp.http.Vary = regsub(bereq.http.Vary, "(^|; ) *User-Agent,? *", "\1"); if (beresp.http.Vary == "") { unset beresp.http.Vary; } } if (beresp.http.X-Cacheable == "NO") { set beresp.uncacheable = true; } else { return (deliver); } } sub vcl_deliver { #Diagnostics if (resp.http.X-Cacheable == "YES") { if (obj.hits > 0) { unset resp.http.X-Cacheable; set resp.http.X-Cache = "HIT"; set resp.http.X-Cache-Hits = obj.hits; } else { set resp.http.X-Cache = "MISS"; } } #Hide sensitive information unset resp.http.X-Varnish; unset resp.http.X-Powered-By; unset resp.http.Via; unset resp.http.Age; #Log server and client IP std.log("X-Server-IP:" + server.ip); std.log("X-Forwarded-For:" + req.http.X-Forwarded-For); return (deliver); } sub vcl_backend_error { include "/etc/varnish/backend-synthetic-error.vcl"; } -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 12:03:43 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 12:03:43 -0000 Subject: [Varnish] #1220: Temporary gzip issue: Invalid Gzip data: incorrect header check In-Reply-To: <057.dbb04d60a18cae71789693faca361b5c@varnish-cache.org> References: <057.dbb04d60a18cae71789693faca361b5c@varnish-cache.org> Message-ID: <072.de70fb0b9f0f05f720530d7d93513724@varnish-cache.org> #1220: Temporary gzip issue: Invalid Gzip data: incorrect header check -------------------------+--------------------- Reporter: jinjian.1@? | Owner: martin Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: 3.0.2 Severity: normal | Resolution: Keywords: stream Gzip | -------------------------+--------------------- Changes (by slink): * cc: nils.goroll@? (added) -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 16:39:46 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 16:39:46 -0000 Subject: [Varnish] #1572: better exit codes - varnishd -C should return correct exit value In-Reply-To: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> References: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> Message-ID: <061.2bb4f1993f2bfd735ca84e10b10fbb7c@varnish-cache.org> #1572: better exit codes - varnishd -C should return correct exit value ----------------------+----------------------- Reporter: zviratko | Owner: slink Type: defect | Status: assigned Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by slink): With the patch to come, I will suggest to make two changes relevant regarding this ticket: * change the wording from "exit x" to "exited with x" so make clear that this is the exit code from the subprobess, not the exit code from varnishd * make the exit codes consistent anyway. Regarding 2), with {{{vcc_err_unref=off}}} the exit code should be zero as unreferenced symbols are not an error. {{{ $ /tmp/sbin/varnishd -p vcc_err_unref=off -C -f /tmp/t.vcl >/dev/null ; echo $? Message from VCC-compiler: Not running as root, no priv-sep Unused sub foo, defined: ('input' Line 8 Pos 5) sub foo { ----###-- (That was just a warning) Function unused ('input' Line 8 Pos 5) sub foo { ----###-- (That was just a warning) Message from C-compiler: Not running as root, no priv-sep Message from dlopen: Not running as root, no priv-sep 0 }}} {{{ $ /tmp/sbin/varnishd -p vcc_err_unref=on -C -f /tmp/t.vcl >/dev/null ; echo $? Message from VCC-compiler: Not running as root, no priv-sep Unused sub foo, defined: ('input' Line 8 Pos 5) sub foo { ----###-- Running VCC-compiler failed, exited with 1 VCL compilation failed 1 }}} {{{ $ cat /tmp/t.vcl vcl 4.0; backend default { .host = "127.0.0.1"; .port = "80"; } sub foo { } }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 17:24:30 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 17:24:30 -0000 Subject: [Varnish] #1579: vcc: conversion to string with + operator incomplete Message-ID: <043.08508ce0f1d194a71a635e91c4b7fd66@varnish-cache.org> #1579: vcc: conversion to string with + operator incomplete ----------------------+--------------------------------- Reporter: slink | Owner: Type: defect | Status: new Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: trunk Severity: normal | Keywords: ----------------------+--------------------------------- v00025.vtc covers tests to convert various types to strings. The same conversions fail if a second string is appended using the + operator. See lines marked with #FAIL# in stringification_fail.vtc A workaround is to start with an empty string and append the variable to be converted, see stringification_workaround.vtc -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 17:30:08 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 17:30:08 -0000 Subject: [Varnish] #1527: Assert error in hcb_insert(), hash/hash_critbit.c line 226: Condition(noh == NULL) not true. In-Reply-To: <044.291983e897d6be23b7193869c25cc93a@varnish-cache.org> References: <044.291983e897d6be23b7193869c25cc93a@varnish-cache.org> Message-ID: <059.a957838a7723e7621945669435a9232e@varnish-cache.org> #1527: Assert error in hcb_insert(), hash/hash_critbit.c line 226: Condition(noh == NULL) not true. ----------------------+----------------------- Reporter: joakim | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Changes (by slink): * status: new => needinfo Comment: joakim, your bugs #1525 #1527 #1528 #1529 could well have a reason outside varnish code. The fact that you have been the only reporter of such fundamental issues seem to support this hypothesis. Do you have any additional insight on these or do you have made progress on either avoiding to run into these issues or being able to reproduce them? -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 17:30:25 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 17:30:25 -0000 Subject: [Varnish] #1528: Assert error in hcb_insert(), hash/hash_critbit.c line 216: Condition((y)->magic == 0x125c4bd2) not true. In-Reply-To: <044.3e68bc8a0e5fc204d4fc9ff752773849@varnish-cache.org> References: <044.3e68bc8a0e5fc204d4fc9ff752773849@varnish-cache.org> Message-ID: <059.fabe8767a8d4151ec1d05e1e69697602@varnish-cache.org> #1528: Assert error in hcb_insert(), hash/hash_critbit.c line 216: Condition((y)->magic == 0x125c4bd2) not true. ----------------------+----------------------- Reporter: joakim | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Changes (by slink): * status: new => needinfo Comment: joakim, your bugs #1525 #1527 #1528 #1529 could well have a reason outside varnish code. The fact that you have been the only reporter of such fundamental issues seem to support this hypothesis. Do you have any additional insight on these or do you have made progress on either avoiding to run into these issues or being able to reproduce them? -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 17:30:37 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 17:30:37 -0000 Subject: [Varnish] #1529: Assert error in hcb_insert(), hash/hash_critbit.c line 260: Condition(y->critbit != y2->critbit) not true. In-Reply-To: <044.e1fc375fbdd7bda441b03cdaac67318b@varnish-cache.org> References: <044.e1fc375fbdd7bda441b03cdaac67318b@varnish-cache.org> Message-ID: <059.9ded2d8cbacf09691a53f85924fc9c2d@varnish-cache.org> #1529: Assert error in hcb_insert(), hash/hash_critbit.c line 260: Condition(y->critbit != y2->critbit) not true. ----------------------+----------------------- Reporter: joakim | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Changes (by slink): * status: new => needinfo Comment: joakim, your bugs #1525 #1527 #1528 #1529 could well have a reason outside varnish code. The fact that you have been the only reporter of such fundamental issues seem to support this hypothesis. Do you have any additional insight on these or do you have made progress on either avoiding to run into these issues or being able to reproduce them? -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 18:02:47 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 18:02:47 -0000 Subject: [Varnish] #1575: Health in random-director does not work In-Reply-To: <042.ba6e81edab67dee0d2d688995d3c45f5@varnish-cache.org> References: <042.ba6e81edab67dee0d2d688995d3c45f5@varnish-cache.org> Message-ID: <057.e56b6ba06e1802391500b67ad8485868@varnish-cache.org> #1575: Health in random-director does not work --------------------+--------------------- Reporter: olli | Owner: martin Type: defect | Status: new Priority: normal | Milestone: Component: build | Version: 4.0.1 Severity: normal | Resolution: Keywords: | --------------------+--------------------- Changes (by slink): * owner: phk => martin -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 18:06:55 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 18:06:55 -0000 Subject: [Varnish] #1579: vcc: conversion to string with + operator incomplete In-Reply-To: <043.08508ce0f1d194a71a635e91c4b7fd66@varnish-cache.org> References: <043.08508ce0f1d194a71a635e91c4b7fd66@varnish-cache.org> Message-ID: <058.a3d4bf8f5a434e5a449b530ed17b7884@varnish-cache.org> #1579: vcc: conversion to string with + operator incomplete ----------------------+---------------------------------- Reporter: slink | Owner: phk Type: defect | Status: new Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: trunk Severity: normal | Resolution: Keywords: | ----------------------+---------------------------------- Changes (by slink): * owner: => phk -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 18:07:34 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 18:07:34 -0000 Subject: [Varnish] #1571: Wrong data type assignment In-Reply-To: <046.c44d2743a9f601241c95101dd892828b@varnish-cache.org> References: <046.c44d2743a9f601241c95101dd892828b@varnish-cache.org> Message-ID: <061.c430d69c7f608fdc2864aaf3278c1d1a@varnish-cache.org> #1571: Wrong data type assignment ----------------------+------------------------ Reporter: zviratko | Owner: phk Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: duplicate Keywords: | ----------------------+------------------------ Changes (by slink): * status: new => closed * resolution: => duplicate Comment: #1579 contains a generalized version of this issue -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Tue Aug 26 21:04:18 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Tue, 26 Aug 2014 21:04:18 -0000 Subject: [Varnish] #1579: vcc: conversion to string with + operator incomplete In-Reply-To: <043.08508ce0f1d194a71a635e91c4b7fd66@varnish-cache.org> References: <043.08508ce0f1d194a71a635e91c4b7fd66@varnish-cache.org> Message-ID: <058.ba211a683a9e13b8f28e1d9f9ce3c233@varnish-cache.org> #1579: vcc: conversion to string with + operator incomplete ----------------------+---------------------------------- Reporter: slink | Owner: phk Type: defect | Status: closed Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: trunk Severity: normal | Resolution: fixed Keywords: | ----------------------+---------------------------------- Changes (by Poul-Henning Kamp ): * status: new => closed * resolution: => fixed Comment: In [5a83b69d8c5d6b08b6de2132df45531c8b7543f1]: {{{ #!CommitTicketReference repository="" revision="5a83b69d8c5d6b08b6de2132df45531c8b7543f1" Rework how we infer types in the VCC expresion evaluator. This mainly (only ?) changes things when we ask for an expression of type STRING or STTRING_LIST. Previously addition and subtraction would follow the general rule, "first argument determines intial type" and that would make an expression like this fail: set resp.http.server_port_foo = std.port(server.ip) + "_foo"; Because the addition tries to evaluate "INT + STRING". The idea was that people would rewrite this as: set resp.http.server_port_foo = "" + std.port(server.ip) + "_foo"; To make the first argument STRING and everything will then just work. However, this is needlessly strict in the case where we are actively desiring the expression to evaluate to STRING -- like above where resp.http.* has type STRING. With the new code, when an impossible addition is encountered, it will look at the type requested of the expression, and if it is STRING, convert the current subexpression to STRING and continue adding. A large number of subtests which are designed to fail started working with this change, they have been fixed by not using *.http.* variables as scaffolding.. You can still get into some weird corner-cases like the difference between: set resp.http.foobar = req.ttl + 1s + "_" + req.ttl + 1s; and set resp.http.foobar = req.ttl + 1s + "_" + req.ttl + 1; and set resp.http.foobar = req.ttl + 1s + "_" + (req.ttl + 1s); (Hint: The last one is the only one which does what you think) Fixes #1579 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 07:30:35 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 07:30:35 -0000 Subject: [Varnish] #1569: having a subroutine named the same as backend results in Symbol not found In-Reply-To: <046.b47c55eccca631613556802863c1030c@varnish-cache.org> References: <046.b47c55eccca631613556802863c1030c@varnish-cache.org> Message-ID: <061.e914153ed111de7ce303ba5a81b7579b@varnish-cache.org> #1569: having a subroutine named the same as backend results in Symbol not found ----------------------+---------------------------------- Reporter: zviratko | Owner: phk Type: defect | Status: closed Priority: normal | Milestone: Varnish 4.0 release Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: | ----------------------+---------------------------------- Changes (by Poul-Henning Kamp ): * status: new => closed * resolution: => fixed Comment: In [996299655c9ed5d94853a495ddaa2ae29094a9e9]: {{{ #!CommitTicketReference repository="" revision="996299655c9ed5d94853a495ddaa2ae29094a9e9" Fix an issue where the order of symbol definition determined if code could compile or not. Fixes #1569 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 08:23:25 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 08:23:25 -0000 Subject: [Varnish] #1529: Assert error in hcb_insert(), hash/hash_critbit.c line 260: Condition(y->critbit != y2->critbit) not true. In-Reply-To: <044.e1fc375fbdd7bda441b03cdaac67318b@varnish-cache.org> References: <044.e1fc375fbdd7bda441b03cdaac67318b@varnish-cache.org> Message-ID: <059.dad59f0784217d230f4dcf212b15aea4@varnish-cache.org> #1529: Assert error in hcb_insert(), hash/hash_critbit.c line 260: Condition(y->critbit != y2->critbit) not true. ----------------------+------------------------ Reporter: joakim | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: duplicate Keywords: | ----------------------+------------------------ Changes (by phk): * status: needinfo => closed * resolution: => duplicate Comment: Duplicate of #1527 -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 08:23:50 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 08:23:50 -0000 Subject: [Varnish] #1528: Assert error in hcb_insert(), hash/hash_critbit.c line 216: Condition((y)->magic == 0x125c4bd2) not true. In-Reply-To: <044.3e68bc8a0e5fc204d4fc9ff752773849@varnish-cache.org> References: <044.3e68bc8a0e5fc204d4fc9ff752773849@varnish-cache.org> Message-ID: <059.f21d9cecd52300ce90b2eb4f6c011732@varnish-cache.org> #1528: Assert error in hcb_insert(), hash/hash_critbit.c line 216: Condition((y)->magic == 0x125c4bd2) not true. ----------------------+------------------------ Reporter: joakim | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: duplicate Keywords: | ----------------------+------------------------ Changes (by phk): * status: needinfo => closed * resolution: => duplicate Comment: Duplicate of #1527 -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 08:26:00 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 08:26:00 -0000 Subject: [Varnish] #1527: Assert error in hcb_insert(), hash/hash_critbit.c line 226: Condition(noh == NULL) not true. In-Reply-To: <044.291983e897d6be23b7193869c25cc93a@varnish-cache.org> References: <044.291983e897d6be23b7193869c25cc93a@varnish-cache.org> Message-ID: <059.ee42988d6fb7b92640d3c4ab7391368c@varnish-cache.org> #1527: Assert error in hcb_insert(), hash/hash_critbit.c line 226: Condition(noh == NULL) not true. ----------------------+----------------------- Reporter: joakim | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by phk): I've merged #1528 and #1529 into this ticket. This does look a lot like some kind of memory corruption or failure. Is this on a system with ECC memory ? You can also try to increase the critbit_cooloff paramter to 254 and see if that helps. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 08:29:54 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 08:29:54 -0000 Subject: [Varnish] #940: For gzip and un-gzip: Change ETags and add Vary In-Reply-To: <043.d3f0122c5f2e8a8e1ed36783de6aff0a@varnish-cache.org> References: <043.d3f0122c5f2e8a8e1ed36783de6aff0a@varnish-cache.org> Message-ID: <058.277ad1e09e1219ec04a56c3c70d61320@varnish-cache.org> #940: For gzip and un-gzip: Change ETags and add Vary ----------------------+-------------------- Reporter: david | Owner: phk Type: defect | Status: new Priority: high | Milestone: Component: build | Version: 3.0.0 Severity: critical | Resolution: Keywords: | ----------------------+-------------------- Comment (by slink): e8e089fc1968ee147fb06c60e3caae568bd11e40 concludes the fix for master / 4.x -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 08:35:49 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 08:35:49 -0000 Subject: [Varnish] #940: For gzip and un-gzip: Change ETags and add Vary In-Reply-To: <043.d3f0122c5f2e8a8e1ed36783de6aff0a@varnish-cache.org> References: <043.d3f0122c5f2e8a8e1ed36783de6aff0a@varnish-cache.org> Message-ID: <058.2d3cda0c9b3ee66aae2b7bf6931fdb2c@varnish-cache.org> #940: For gzip and un-gzip: Change ETags and add Vary ----------------------+-------------------- Reporter: david | Owner: Type: defect | Status: new Priority: high | Milestone: Component: build | Version: 3.0.0 Severity: critical | Resolution: Keywords: | ----------------------+-------------------- Changes (by phk): * owner: phk => -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 09:13:55 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 09:13:55 -0000 Subject: [Varnish] #1528: Assert error in hcb_insert(), hash/hash_critbit.c line 216: Condition((y)->magic == 0x125c4bd2) not true. In-Reply-To: <044.3e68bc8a0e5fc204d4fc9ff752773849@varnish-cache.org> References: <044.3e68bc8a0e5fc204d4fc9ff752773849@varnish-cache.org> Message-ID: <059.4bd768f8f41d05b4a54145d17beeb583@varnish-cache.org> #1528: Assert error in hcb_insert(), hash/hash_critbit.c line 216: Condition((y)->magic == 0x125c4bd2) not true. ----------------------+------------------------ Reporter: joakim | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: duplicate Keywords: | ----------------------+------------------------ Comment (by joakim): Replying to [comment:3 slink]: > joakim, your bugs #1525 #1527 #1528 #1529 could well have a reason outside varnish code. The fact that you have been the only reporter of such fundamental issues seem to support this hypothesis. Do you have any additional insight on these or do you have made progress on either avoiding to run into these issues or being able to reproduce them? Sorry, I'm on parental leave right now so progress has been "kind of slow". There could of course be some outside factor but don't really know what that would be as the same servers ran Varnish 3 without any problems. Will see if I find some time to try things out in the coming month(s). -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 09:16:28 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 09:16:28 -0000 Subject: [Varnish] #1527: Assert error in hcb_insert(), hash/hash_critbit.c line 226: Condition(noh == NULL) not true. In-Reply-To: <044.291983e897d6be23b7193869c25cc93a@varnish-cache.org> References: <044.291983e897d6be23b7193869c25cc93a@varnish-cache.org> Message-ID: <059.0b4681667bcc07e3da3890f639fa0bff@varnish-cache.org> #1527: Assert error in hcb_insert(), hash/hash_critbit.c line 226: Condition(noh == NULL) not true. ----------------------+----------------------- Reporter: joakim | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.0 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by joakim): Replying to [comment:2 phk]: > I've merged #1528 and #1529 into this ticket. > > This does look a lot like some kind of memory corruption or failure. > > Is this on a system with ECC memory ? > Yes, both servers have ECC memory. I've tried running memtest, which reported everything was OK and as I mentioned in another case; the same servers ran Varnish 3 without ever crashing. > You can also try to increase the critbit_cooloff paramter to 254 and see if that helps. OK, will try that out. Any ideas, no matter how harebrained, are welcome at this stage. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 10:02:22 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 10:02:22 -0000 Subject: [Varnish] #1566: escape sequence breaks regex In-Reply-To: <048.96582f05e1f84174e2f554fa6d8ea786@varnish-cache.org> References: <048.96582f05e1f84174e2f554fa6d8ea786@varnish-cache.org> Message-ID: <063.fceff56379f94fa71bad4068e9d31f78@varnish-cache.org> #1566: escape sequence breaks regex ------------------------+---------------------------------------- Reporter: RWOverdijk | Owner: Poul-Henning Kamp Type: defect | Status: closed Priority: normal | Milestone: Component: build | Version: unknown Severity: normal | Resolution: fixed Keywords: | ------------------------+---------------------------------------- Changes (by Poul-Henning Kamp ): * status: new => closed * owner: => Poul-Henning Kamp * resolution: => fixed Comment: In [ad0ae8ee6cb158c5aa5f60e5077459d92331677a]: {{{ #!CommitTicketReference repository="" revision="ad0ae8ee6cb158c5aa5f60e5077459d92331677a" Escape question marks in C-strings to avoid accidentally generating tri-graphs. Fixes #1566 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 10:09:28 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 10:09:28 -0000 Subject: [Varnish] #1580: varnishd does not consider -a param Message-ID: <048.2a0b53d943cfeb5bbd60300af37f41c3@varnish-cache.org> #1580: varnishd does not consider -a param ------------------------+---------------------- Reporter: our_martin | Type: defect Status: new | Priority: normal Milestone: | Component: varnishd Version: trunk | Severity: major Keywords: | ------------------------+---------------------- varnishd does not consider -a param but chooses a random(?) port on localhost instead: {{{ martin at martin-notebook:/tmp$ pkill varnishd martin at martin-notebook:/tmp$ ps -ef | grep varnishd | grep -v grep martin at martin-notebook:/tmp$ /opt/varnish/sbin/varnishd -a "127.0.0.1:6081" martin at martin-notebook:/tmp$ /opt/varnish/sbin/varnishd -a 127.0.0.1:6081 martin at martin-notebook:/tmp$ /opt/varnish/sbin/varnishd -a :6081 martin at martin-notebook:/tmp$ sudo lsof -i4 -nP | grep LISTEN | grep varnishd varnishd 21138 martin 4u IPv4 755276 0t0 TCP 127.0.0.1:49115 (LISTEN) varnishd 21142 martin 4u IPv4 755292 0t0 TCP 127.0.0.1:49479 (LISTEN) varnishd 21146 martin 4u IPv4 755297 0t0 TCP 127.0.0.1:53716 (LISTEN) martin at martin-notebook:/tmp$ }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 10:21:27 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 10:21:27 -0000 Subject: [Varnish] #1580: varnishd does not consider -a param In-Reply-To: <048.2a0b53d943cfeb5bbd60300af37f41c3@varnish-cache.org> References: <048.2a0b53d943cfeb5bbd60300af37f41c3@varnish-cache.org> Message-ID: <063.6b29eb062558d96701334bf983d0cae9@varnish-cache.org> #1580: varnishd does not consider -a param ------------------------+-------------------- Reporter: our_martin | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: major | Resolution: Keywords: | ------------------------+-------------------- Comment (by our_martin): ok, I did not give a vcl oder -b. would be nice to have a warning/error- message. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 10:23:11 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 10:23:11 -0000 Subject: [Varnish] #1580: varnishd should warn/fail when both -b and -f argument are missing but -a present (was: varnishd does not consider -a param) In-Reply-To: <048.2a0b53d943cfeb5bbd60300af37f41c3@varnish-cache.org> References: <048.2a0b53d943cfeb5bbd60300af37f41c3@varnish-cache.org> Message-ID: <063.3b83abd3fe157570365243e733969a62@varnish-cache.org> #1580: varnishd should warn/fail when both -b and -f argument are missing but -a present ------------------------+-------------------- Reporter: our_martin | Owner: slink Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: major | Resolution: Keywords: | ------------------------+-------------------- Changes (by slink): * owner: => slink -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 10:43:56 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 10:43:56 -0000 Subject: [Varnish] #1581: Duplicate SLT_Begin log records Message-ID: <043.8743f789155e60115173c7fa6383b726@varnish-cache.org> #1581: Duplicate SLT_Begin log records ----------------------+------------------- Reporter: daghf | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: normal | Keywords: ----------------------+------------------- Master as of some time lately is logging duplicate Begin records, with the result that we end up with duplicate empty transactions in varnishlog. Output from 'varnishlog -g request', after firing off a single request: {{{ * << Request >> 2 - Begin req 1 rxreq - End * << Request >> 3 - Begin req 1 rxreq - Timestamp Start: 1409135790.046865 0.000000 0.000000 - Timestamp Req: 1409135790.046865 0.000000 0.000000 - ReqStart 127.0.0.1 35995 - ReqMethod GET - ReqURL / }}} Note that the Begin record in request 2 is identical to the one in request 3. Behavior is not unique to '-g request', this applies for all -g modes. varnishd command line: {{{ $ varnishd -F -a :9090 -n /tmp/foo -b localhost:8080 }}} Version is HEAD of master branch as of right now (ad0ae8e). -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 11:10:48 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 11:10:48 -0000 Subject: [Varnish] #1582: Varnish internal header field comparisons must be case insensitive Message-ID: <043.7aa76d19c343ed70d4990c8dfe54f4fc@varnish-cache.org> #1582: Varnish internal header field comparisons must be case insensitive --------------------+--------------------- Reporter: slink | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: build | Version: unknown Severity: normal | Keywords: --------------------+--------------------- http_GetHdrData is case-sensitive, but shouldn't be -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 11:11:03 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 11:11:03 -0000 Subject: [Varnish] #1582: Varnish internal header field comparisons must be case insensitive In-Reply-To: <043.7aa76d19c343ed70d4990c8dfe54f4fc@varnish-cache.org> References: <043.7aa76d19c343ed70d4990c8dfe54f4fc@varnish-cache.org> Message-ID: <058.87a31dc62219c9732415c105dbe0a7f4@varnish-cache.org> #1582: Varnish internal header field comparisons must be case insensitive --------------------+---------------------- Reporter: slink | Owner: slink Type: defect | Status: new Priority: normal | Milestone: Component: build | Version: unknown Severity: normal | Resolution: Keywords: | --------------------+---------------------- Changes (by slink): * owner: => slink -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 12:21:15 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 12:21:15 -0000 Subject: [Varnish] #1582: Varnish internal header field comparisons must be case insensitive In-Reply-To: <043.7aa76d19c343ed70d4990c8dfe54f4fc@varnish-cache.org> References: <043.7aa76d19c343ed70d4990c8dfe54f4fc@varnish-cache.org> Message-ID: <058.6be57cb61b392a9c2c79f0f8e6e6d1c0@varnish-cache.org> #1582: Varnish internal header field comparisons must be case insensitive --------------------+---------------------- Reporter: slink | Owner: slink Type: defect | Status: closed Priority: normal | Milestone: Component: build | Version: unknown Severity: normal | Resolution: fixed Keywords: | --------------------+---------------------- Changes (by Nils Goroll ): * status: new => closed * resolution: => fixed Comment: In [b109ee1c099ebae6a9f9423b1a1f81c634c8f895]: {{{ #!CommitTicketReference repository="" revision="b109ee1c099ebae6a9f9423b1a1f81c634c8f895" Fix sensitivity for header token matching. Rename GetHdrData -> GetHdrToken Section 4.2 (Messages Headers) of RFC2616 defines field (header) name as case insensitive, but the field (header) value/content may be case-sensitive. http_GetHdrToken looks up a token in a header value and the rfc does not say explicitly if tokens are to be compared with or without respect to case. But all examples and specific statements regarding tokens follow the rule that unquoted tokens are to be matched case-insensitively and quoted tokens case-sensitively. Fixes #1582 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 15:34:04 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 15:34:04 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 In-Reply-To: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> References: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> Message-ID: <057.32d3e7a5e091a46ef0f130aa68032616@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 ----------------------+----------------------- Reporter: abdi | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by abdi): FYI. I have compiled varnish myself this time with pcre-jit enabled (--enable- pcre-jit) and I still get varnish crashing with segfault. https://github.com/varnish/Varnish- Cache/commit/791706d8e535fe1573a6ea5cd515113ddacbac52 -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 15:52:07 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 15:52:07 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 In-Reply-To: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> References: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> Message-ID: <057.149ccb181b4507f96a66400e92c48829@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 ----------------------+----------------------- Reporter: abdi | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by fgsch): Thanks. Is this something you can reproduce or crashes randomly after some time? If so if you could follow the steps at https://www.varnish- cache.org/trac/wiki/DebuggingVarnish to get a useful coredump it'd be appreciated. Also trying to pinpoint which regex and/or request is causing the crash would be great. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 15:55:20 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 15:55:20 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 In-Reply-To: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> References: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> Message-ID: <057.97bbea0e694584450614aae028b29578@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 ----------------------+----------------------- Reporter: abdi | Owner: Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by abdi): I can't reproduce the regex/request that causing the crash but it is happening frequently. I already took a coredump but it was too big to attach to this ticket. let me know other ways to get this coredump to you. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 18:18:24 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 18:18:24 -0000 Subject: [Varnish] #940: For gzip and un-gzip: Change ETags and add Vary In-Reply-To: <043.d3f0122c5f2e8a8e1ed36783de6aff0a@varnish-cache.org> References: <043.d3f0122c5f2e8a8e1ed36783de6aff0a@varnish-cache.org> Message-ID: <058.febd35ef59e27bfcc731923a349f01c8@varnish-cache.org> #940: For gzip and un-gzip: Change ETags and add Vary ----------------------+-------------------- Reporter: david | Owner: slink Type: defect | Status: new Priority: high | Milestone: Component: build | Version: 3.0.0 Severity: critical | Resolution: Keywords: | ----------------------+-------------------- Changes (by slink): * owner: => slink -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 19:53:13 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 19:53:13 -0000 Subject: [Varnish] #1583: revisit solaris sandbox fatal error handling Message-ID: <043.2347ee3a8140e28771f796e7a7d5fc15@varnish-cache.org> #1583: revisit solaris sandbox fatal error handling ----------------------+--------------------- Reporter: slink | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: unknown Severity: normal | Keywords: ----------------------+--------------------- can we assert there or do we really need to report and exit? -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 19:53:18 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 19:53:18 -0000 Subject: [Varnish] #1583: revisit solaris sandbox fatal error handling In-Reply-To: <043.2347ee3a8140e28771f796e7a7d5fc15@varnish-cache.org> References: <043.2347ee3a8140e28771f796e7a7d5fc15@varnish-cache.org> Message-ID: <058.b5fe124609221e928c9257fcda8ca50a@varnish-cache.org> #1583: revisit solaris sandbox fatal error handling ----------------------+---------------------- Reporter: slink | Owner: slink Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: unknown Severity: normal | Resolution: Keywords: | ----------------------+---------------------- Changes (by slink): * owner: => slink -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Wed Aug 27 19:55:26 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Wed, 27 Aug 2014 19:55:26 -0000 Subject: [Varnish] #1572: better exit codes - varnishd -C should return correct exit value In-Reply-To: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> References: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> Message-ID: <061.2915d8d6fafe5560f643deb04928f52b@varnish-cache.org> #1572: better exit codes - varnishd -C should return correct exit value ----------------------+----------------------- Reporter: zviratko | Owner: slink Type: defect | Status: assigned Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by slink): discussed patch with phk. TODO: * swap status codes 1 and 2 (the more severe the higher) * commit individual programs -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 28 10:42:28 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 28 Aug 2014 10:42:28 -0000 Subject: [Varnish] #1572: better exit codes - varnishd -C should return correct exit value In-Reply-To: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> References: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> Message-ID: <061.6ed7a8115c08d42cc17d2e3f432ca016@varnish-cache.org> #1572: better exit codes - varnishd -C should return correct exit value ----------------------+--------------------- Reporter: zviratko | Owner: slink Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: | ----------------------+--------------------- Comment (by Nils Goroll ): In [dae4ceeb6b6a310f254c22b60f674c9dfaf3999d]: {{{ #!CommitTicketReference repository="" revision="dae4ceeb6b6a310f254c22b60f674c9dfaf3999d" tools: streamline exit codes, fix exit codes for vsubs This should bring us closer to the exit codes now documented in varnishd.rst Fixes #1572 for tools }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 28 10:42:28 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 28 Aug 2014 10:42:28 -0000 Subject: [Varnish] #1572: better exit codes - varnishd -C should return correct exit value In-Reply-To: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> References: <046.db75c8527071670bee1f16144d3a434a@varnish-cache.org> Message-ID: <061.19075711db965d78552442b6e147411f@varnish-cache.org> #1572: better exit codes - varnishd -C should return correct exit value ----------------------+--------------------- Reporter: zviratko | Owner: slink Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: fixed Keywords: | ----------------------+--------------------- Changes (by Nils Goroll ): * status: assigned => closed * resolution: => fixed Comment: In [33e6fe71743059b912d2b00cdbc08196b003e440]: {{{ #!CommitTicketReference repository="" revision="33e6fe71743059b912d2b00cdbc08196b003e440" varnishd: streamline exit codes, fix exit codes for vsubs This should bring us closer to the exit codes now documented in varnishd.rst Fixes #1572 for varnishd }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 28 13:53:07 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 28 Aug 2014 13:53:07 -0000 Subject: [Varnish] #1378: varnishncsa does not escape log items In-Reply-To: <046.c965e13022034e658e261f1b7ddb7f49@varnish-cache.org> References: <046.c965e13022034e658e261f1b7ddb7f49@varnish-cache.org> Message-ID: <061.2b96fd506676a7ba51fd90db64e8f565@varnish-cache.org> #1378: varnishncsa does not escape log items -------------------------+--------------------- Reporter: simonvik | Owner: aondio Type: defect | Status: new Priority: low | Milestone: Component: varnishncsa | Version: 3.0.4 Severity: minor | Resolution: Keywords: | -------------------------+--------------------- Changes (by lkarsten): * owner: martin => aondio -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 28 13:55:26 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 28 Aug 2014 13:55:26 -0000 Subject: [Varnish] #1584: varnishncsa: format_requestline missing whitespace Message-ID: <043.005d215214c91003c1a275be2fd711ca@varnish-cache.org> #1584: varnishncsa: format_requestline missing whitespace -------------------+------------------------- Reporter: stone | Type: defect Status: new | Priority: normal Milestone: | Component: varnishncsa Version: trunk | Severity: normal Keywords: | -------------------+------------------------- varnishncsa format_requestline is missing whitespace after url. {{{- - - [28/Aug/2014:15:19:42 +0200] "- http://localhost- HTTP/1.0" - 0 "-" "-"}}} note the "http://localhost-" part. Should probably be: {{{- - - [28/Aug/2014:15:19:42 +0200] "- http://localhost - HTTP/1.0" - 0 "-" "-"}}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 28 17:18:58 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 28 Aug 2014 17:18:58 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 In-Reply-To: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> References: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> Message-ID: <057.06ccc03572b23ac21419a082a978ddd5@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 ----------------------+----------------------- Reporter: abdi | Owner: fgsch Type: defect | Status: assigned Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Changes (by fgsch): * status: needinfo => assigned * owner: => fgsch -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Thu Aug 28 17:19:17 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Thu, 28 Aug 2014 17:19:17 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 In-Reply-To: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> References: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> Message-ID: <057.17909ed87db79606f7dc9f966eb2b261@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 ----------------------+----------------------- Reporter: abdi | Owner: fgsch Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Changes (by fgsch): * status: assigned => needinfo -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 29 10:43:34 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 29 Aug 2014 10:43:34 -0000 Subject: [Varnish] #1585: fatal sandbox errors are not fatal to varnishd Message-ID: <043.4abf283d80b5b78696ff6dc3bb4ea648@varnish-cache.org> #1585: fatal sandbox errors are not fatal to varnishd ----------------------+------------------- Reporter: slink | Owner: slink Type: defect | Status: new Priority: high | Milestone: Component: varnishd | Version: trunk Severity: major | Keywords: ----------------------+------------------- noticed working on #1583: When provoking a panic in the sandbox code, varnishd still exits with 0. Could be a regression from #1572 / 33e6fe71743059b912d2b00cdbc08196b003e440 - I will fix this ASAP {{{ > /.../sbin/varnishd -a 127.0.0.1:8088 -b 127.0.0.1:80 Message from VCC-compiler: Incompelte code in mgt_sandbox_solaris_add_inheritable(), mgt/mgt_sandbox_solaris.c line 223: errno = 9 (Bad file number) Running VCC-compiler failed, signal 6, core dumped Message from C-compiler: Incompelte code in mgt_sandbox_solaris_add_inheritable(), mgt/mgt_sandbox_solaris.c line 223: errno = 9 (Bad file number) Running C-compiler failed, signal 6, core dumped Message from dlopen: Incompelte code in mgt_sandbox_solaris_add_inheritable(), mgt/mgt_sandbox_solaris.c line 223: errno = 9 (Bad file number) Running dlopen failed, signal 6, core dumped > echo $? 0 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 29 10:44:48 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 29 Aug 2014 10:44:48 -0000 Subject: [Varnish] #1585: fatal sandbox errors are not fatal to varnishd In-Reply-To: <043.4abf283d80b5b78696ff6dc3bb4ea648@varnish-cache.org> References: <043.4abf283d80b5b78696ff6dc3bb4ea648@varnish-cache.org> Message-ID: <058.ca66ca1d51857d402e5e7a65fc20cd7a@varnish-cache.org> #1585: fatal sandbox errors are not fatal to varnishd ----------------------+-------------------- Reporter: slink | Owner: slink Type: defect | Status: new Priority: high | Milestone: Component: varnishd | Version: trunk Severity: major | Resolution: Keywords: | ----------------------+-------------------- Comment (by slink): Just to make this clear: The INCOMPL() was added deliberately, there is no (known) issue in the solaris sandbox code. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 29 12:42:27 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 29 Aug 2014 12:42:27 -0000 Subject: [Varnish] #1585: fatal sandbox errors are not fatal to varnishd In-Reply-To: <043.4abf283d80b5b78696ff6dc3bb4ea648@varnish-cache.org> References: <043.4abf283d80b5b78696ff6dc3bb4ea648@varnish-cache.org> Message-ID: <058.75be2be51c15fd4a139a4b1fd48d891b@varnish-cache.org> #1585: fatal sandbox errors are not fatal to varnishd ----------------------+-------------------- Reporter: slink | Owner: slink Type: defect | Status: new Priority: high | Milestone: Component: varnishd | Version: trunk Severity: major | Resolution: Keywords: | ----------------------+-------------------- Comment (by slink): Test result with the fix to be committed: {{{ > /.../sbin/varnishd -a 127.0.0.1:8088 -b 127.0.0.1:80 Message from VCC-compiler: Incomplete code in mgt_sandbox_solaris_add_inheritable(), mgt/mgt_sandbox_solaris.c line 223: errno = 9 (Bad file number) Running VCC-compiler failed, signal 6, core dumped VCL compilation failed > echo $? 2 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 29 12:45:55 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 29 Aug 2014 12:45:55 -0000 Subject: [Varnish] #1585: fatal sandbox errors are not fatal to varnishd In-Reply-To: <043.4abf283d80b5b78696ff6dc3bb4ea648@varnish-cache.org> References: <043.4abf283d80b5b78696ff6dc3bb4ea648@varnish-cache.org> Message-ID: <058.5ea775b65c76932913813de9cac46408@varnish-cache.org> #1585: fatal sandbox errors are not fatal to varnishd ----------------------+--------------------- Reporter: slink | Owner: slink Type: defect | Status: closed Priority: high | Milestone: Component: varnishd | Version: trunk Severity: major | Resolution: fixed Keywords: | ----------------------+--------------------- Changes (by Nils Goroll ): * status: new => closed * resolution: => fixed Comment: In [be4def865167e6d20fec7f67aa7cfa245928ea95]: {{{ #!CommitTicketReference repository="" revision="be4def865167e6d20fec7f67aa7cfa245928ea95" Return 2 from VSUB_run() when the sub process dies with a signal. Fixes a regression from 33e6fe71743059b912d2b00cdbc08196b003e440 Fixes #1585 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 29 12:51:17 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 29 Aug 2014 12:51:17 -0000 Subject: [Varnish] #1583: revisit solaris sandbox fatal error handling In-Reply-To: <043.2347ee3a8140e28771f796e7a7d5fc15@varnish-cache.org> References: <043.2347ee3a8140e28771f796e7a7d5fc15@varnish-cache.org> Message-ID: <058.d55faae044f3305d065e6d482c3f8b1b@varnish-cache.org> #1583: revisit solaris sandbox fatal error handling ----------------------+---------------------- Reporter: slink | Owner: slink Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: unknown Severity: normal | Resolution: fixed Keywords: | ----------------------+---------------------- Changes (by Nils Goroll ): * status: new => closed * resolution: => fixed Comment: In [b786d418992467ca97046df9273f3b65d28b6486]: {{{ #!CommitTicketReference repository="" revision="b786d418992467ca97046df9273f3b65d28b6486" panic with INCOMPL() rather than exit(4) Fixes #1583 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 29 13:37:46 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 29 Aug 2014 13:37:46 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 In-Reply-To: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> References: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> Message-ID: <057.a1c0710da821723d483f90f8bedb0136@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 ----------------------+----------------------- Reporter: abdi | Owner: fgsch Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by slink): Does this also happen when you disable pcre jit? -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 29 13:40:58 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 29 Aug 2014 13:40:58 -0000 Subject: [Varnish] #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 In-Reply-To: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> References: <042.4a3d8a5cb69dc6179ad46be4f593a479@varnish-cache.org> Message-ID: <057.e428d61d21b832d12b2c6827d01143ad@varnish-cache.org> #1576: varnishd child process crashes with segfault error 6 in libpcre.so.3.13.1 ----------------------+----------------------- Reporter: abdi | Owner: fgsch Type: defect | Status: needinfo Priority: normal | Milestone: Component: varnishd | Version: 4.0.1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------- Comment (by abdi): yes it happen when its enabled and also disabled. it's disabled by default in varnish4. -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 29 13:48:49 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 29 Aug 2014 13:48:49 -0000 Subject: [Varnish] #1580: varnishd should warn/fail when both -b and -f argument are missing but -a present In-Reply-To: <048.2a0b53d943cfeb5bbd60300af37f41c3@varnish-cache.org> References: <048.2a0b53d943cfeb5bbd60300af37f41c3@varnish-cache.org> Message-ID: <063.5bec3e9ddcc39a09ef29426f958199b5@varnish-cache.org> #1580: varnishd should warn/fail when both -b and -f argument are missing but -a present ------------------------+--------------------- Reporter: our_martin | Owner: slink Type: defect | Status: closed Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: major | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by Nils Goroll ): * status: new => closed * resolution: => fixed Comment: In [03e41c53a6251bc606c183db2dd1e6ec26c63d2e]: {{{ #!CommitTicketReference repository="" revision="03e41c53a6251bc606c183db2dd1e6ec26c63d2e" Add an informative warning when only starting the master process in daemon mode Fixes #1580 }}} -- Ticket URL: Varnish The Varnish HTTP Accelerator From varnish-bugs at varnish-cache.org Fri Aug 29 16:10:55 2014 From: varnish-bugs at varnish-cache.org (Varnish) Date: Fri, 29 Aug 2014 16:10:55 -0000 Subject: [Varnish] #1581: Duplicate SLT_Begin log records In-Reply-To: <043.8743f789155e60115173c7fa6383b726@varnish-cache.org> References: <043.8743f789155e60115173c7fa6383b726@varnish-cache.org> Message-ID: <058.23159c1abebf57231300d20f7449d2da@varnish-cache.org> #1581: Duplicate SLT_Begin log records ----------------------+-------------------- Reporter: daghf | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: varnishd | Version: trunk Severity: normal | Resolution: Keywords: | ----------------------+-------------------- Comment (by daghf): With good help from Martin, we found that this behavior can only be triggered in the case of a client being slow at transmitting the request after connect. This was the case with lwp-request on a 4 yr old thinkpad. I've attached a test case we came up with that consistently reproduces the behavior by including a tiny delay just prior to sending the request. -- Ticket URL: Varnish The Varnish HTTP Accelerator